Webform Accordion

welcome,

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 .

git checkout 7.x-1.x
git branch -D master
git push origin :master

An automated review of your project looks good, the issues shown are false positive (required functions of webform) (note to other reviewers)

There are about 100 other applications waiting for review and only a hand full of active reviewers.
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

One very basic observation from the module file that the function,

function webform_accordion_insert_js_css() {
  $embedded = drupal_static(__FUNCTION__);

  if (!$embedded) {
    drupal_add_library('system', 'ui');
    drupal_add_library('system', 'ui.widget');
    drupal_add_library('system', 'ui.accordion');
    drupal_add_js(drupal_get_path('module', 'webform_accordion') . '/js/webform_accordion.js');

    $embedded = TRUE;
  }
}

why should I do that static variable set to "true" at the end of function. Because drupal_static() will return an empty value the first time we call it, but any changes to the variable will be preserved when the function is called again. That means that our function can check if the variable is already populated, and return it immediately without doing any more work
It seems to me that without resetting to true still those library will be cached during page request by using the default behavior of drupal_static

drupal_static is basically an use of caching mechanism handling for a single page request where actually I can write my expensive logics... and using drupal_static_reset we can just reset the cache & executes the normal process once again

Checked this out on my local. Looks good.

Thanks for your contribution, Shawn_Smiley!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.