The URL Alias Permissions module allows site administrators to set permissions to create and edit url path settings by content type. Not all content types are meant to be viewed as pages and creating an URL alias for those content types might be irrelevant, hide those settings for those users would be useful. Or you may want to use path auto to create the url alias and you don't want the admin to be able to override those content types but you do want them to be able to create url aliases for content types like pages or webforms.

Project Page: http://drupal.org/sandbox/jtphelan/1713044
Repository: git clone --recursive --branch master jtphelan@git.drupal.org:sandbox/jtphelan/1713044.git url_alias_permissions
Drupal Version 7

Comments

amitgoyal’s picture

amitgoyal commented
Status: Needs review » Needs work

Hello jphelan,

Firstly, you should not be working on a master branch, instead work on a version specific branch, Branching Instruction here - http://drupal.org/node/1127732
Secondly, your info file is not upto the mark, Check here for instructions - http://drupal.org/node/542202
Also, you can check the automated review of your project here - http://ventral.org/pareview/httpgitdrupalorgsandboxjtphelan1713044git

amitgoyal’s picture

amitgoyal commented

More points to fix,

url_alias_permissions.info
- missing, core = 7.x
- missing, description = description about your module

url_alias_permissions.module
- not able to install the module as core = 7.x is missing in url_alias_permissions.info
- you need to put your code in 7.x-1.x branch and need to delete master branch

README.txt
- this file is missing.

After I added core = 7.x in .info and tested it on my local system, it worked perfectly fine. You have achieved the functionality in very less code. That's great!

jphelan’s picture

jphelan commented

amitgoyal thanks for the review. I believe I've updated the module to meet all the Drupal standard and changes you mentioned above.

jphelan’s picture

jphelan commented
Status: Needs work » Needs review
dwieeb’s picture

dwieeb commented
Status: Needs review » Needs work

Hi,

  • While yes, you are implementing hook_form_FORM_ID_alter(), don't forget to document which form you are altering. See this section of the documentation standards. Your comment block should end up looking like this:
    /**
 * Implements hook_form_FORM_ID_alter() for node_form().
 *
 * Check if they have access to set the path for the content type.
 */
  • Your .info file needs a newline at the end of the file.
  • Your @file comment block has a line that exceeds 80 characters.

Not much else to say, short and sweet little module that does its job. Have you considered expanding the functionality to add permissions to each vertical tab in the node form?

patrickd’s picture

patrickd commented
Status: Needs work » Needs review

None of the issues you pointed out are major -> no requirement -> no needs work.

jphelan’s picture

jphelan commented

I've addressed dwieeb's three documentation changes.

dwieeb - I've not considered expanding the functionality as Override Node Options provides most of that functionality already. But I'm always open to ideas.

amitgoyal’s picture

amitgoyal commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » klausi
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: klausi » Unassigned
Status: Reviewed & tested by the community » Fixed

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed.

Thanks for your contribution, jphelan !

I promoted this project for you. Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

jphelan’s picture

jphelan commented

Thanks klausi, i totally understand that this project is too short to approve me as git vetted user. Thanks for all the info, I'm very interested in getting more involved so I will take a look at it all.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.