A Drupal 7 module that allows admins to create, name, and organize arbitrary blocks of tracking code and inject them into the HEAD or BODY tags of a Drupal page. Individual snippets operate on white/black list visibility similar to the Drupal core block module.

http://drupal.org/sandbox/ColonelForbinX/1717730

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

serjas’s picture

serjas commented

Hi , first try to fix coding errors on http://ventral.org/pareview/httpgitdrupalorgsandboxcolonelforbinx1717730git

manual review
# create a subbranch and remove master .Details here http://drupal.org/node/1127732
# .info is not properly formatted, specify core = 7.x
# try to use t() wherever possible .For example 'title' => t('Edit Tracking Code')
# in .module line 38 ,try to use l() instead of direct a href html to avoid error on sites without cleanurl (when i tested local , it gives page not found )
# in 55,56 : no need to provide $base_url inside l() . it should be l($text, $path) , without a '/' at starting
# disable (via ajax), is not working
# suggestion : try to use l() wherever possible , for example in Line 54 (you can use attributes to add classes)

module is working perfectly, tested adding google analytic script before </body> , working fine, nice module :)

serjas’s picture

serjas commented
Status: Needs review » Needs work
ColonelForbinX’s picture

ColonelForbinX commented
Status: Needs work » Needs review

Thanks so much for your help, serjas. I have subsequently installed CodeSniffer for future use, and have met its Drupal standards criteria for each file. I was using Coder module up until now, but I think this will prove to be much more handy for reviewing other modules, as well as my own code.

Changes Made:

  • Brought code styling and documentation up to Coder Module & CodeSniffer standards.
  • Fixed broken AJAX link and used Drupal's l() function where applicable.
  • Added t() in all areas where it was not being used.
serjas’s picture

serjas commented
Status: Needs review » Needs work

minor error - line 3 : Files must end in a single new line character :)

README.txt is missing, also delete master branch (check http://drupal.org/node/1127732)

manual review :
seems everything okay

serjas’s picture

serjas commented
Status: Needs work » Reviewed & tested by the community
misc’s picture

misc commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, serjas!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

ColonelForbinX’s picture

ColonelForbinX commented

So I've followed the instructions on http://drupal.org/node/1068952 (article on promoting sandbox projects to full projects), and I don't seem to have the necessary "Promote" tab mentioned. Is it possible my account has not been updated, or is there some other step that I missed?

patrickd’s picture

patrickd commented

yep, misc missed that one, now your really promoted

ColonelForbinX’s picture

ColonelForbinX commented

Many thanks MiSc & patrickd!
:)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.