Popular Tags

welcome,

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxjiteshdoshi1751332git

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

What sets this module apart is that it leaves the autocomplete field for terms exactly the way it would be without it, only adding a simple list to make adding terms a bit easier. Perfect for those that need something non-intrusive. Nevertheless it might be useful to mention other differences with http://drupal.org/project/active_tags (e.i. count, etc.).

Every contributed module should provide a README.txt in the package. For further details: http://drupal.org/node/161085#readme

In the .css file margin-left and margin-right are used. Drupal supports conditional loading of CSS files with specific override rules for right-to-left languages. See http://drupal.org/node/302199.

Good job, happy coding.

popular_tags.widget.inc:
Line 80: Add the column 'name' for ordening:
ORDER BY count DESC, name
This results in alfabetic ordening of terms with the same count. Noticed this is often but not always the case. You can also consider to use 'weight' instead.

popular_tags.css:
Remove lines 10 and on. When no limit is given terms are not bold and when there is a limit (popular only) they turn bold. Bolding makes readability worse anyway.

Add a section "Related projects" to the project page with the differences between your module and similar ones, most notably Active Tags.

Considering these are minors, changing status to RTBC.

The term "related projects" might be a bit confusing because it can also be found in the right column of a full project page. Maybe it's better to call it "Similar modules" . What I meant is a paragraph on the project page itself.

"What else needs to be done to make it a top-level, full project?"
Getting a review bonus helps to get the attention of one of the administrators here. Most people that review your project are seeking a bonus, including me. It takes some practice and time, but it's fair, educational and fun at the same time. I learned a couple of new things by studying your code.

From your project page:
"Active Tags is somewhat similar, but targets a different problem - namely showing the tags that have been added, rather than listing tags that you can add."

You are right. I wasn't aware of this because I used the D6 version of Active Tags. That version had similar functionality as your module in the form of a sub-module (Active Tags Popular), but unfortunately that got lost with the D7 upgrade. I cross-posted a link to your sandbox in the issue queue there.

Great module. Thanks.

The module works as expected and I see no security issues from another side there is not enough code to grant full project promotion rights (at least 5 functions and 120 lines of php code) but it can be approved as a single project.

Thanks for your contribution, Jitesh Doshi!

I promoted this to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Since we also count the Javascript I would say this is enough, so I granted you the git vetted user role. Thanks Jitesh Doshi!

Gratz Jitesh Doshi :-)

@Klausi: Oki I will count JS for nexts RTBC's