Field required by role is a module that improves core "required" functionality.

Similar to CCK Required by role brings extra features such as:

Doesn´t need extra configuration, just install.
Recpects previous configuration.
Configuration per field instance.
Valid for all entities, it includes custom entities.

Basic information

Project Link: http://drupal.org/sandbox/lord_of_freaks/1759224
Git Link:
git clone --recursive --branch 7.x-1.x lord_of_freaks@git.drupal.org:sandbox/lord_of_freaks/1759224.git required_by_role

Drupal version: 7
PAReview: http://ventral.org/pareview/httpgitdrupalorgsandboxlordoffreaks1759224git

Reviews of other projects

Password field
Soshake
Autofloat

Comments

klausi’s picture

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

dharam1987’s picture

Hello,

I have installed and reviewed your module. I have created few user roles and have also created few custom fields for one of my content type "Article", I have provided different access to different users and it seems to be working fine and does what it says.

I have tried all the possible ways and it has passed all my test cases. This is a simple module, but I think the functionality it provides can be used to a greater extent for highly content driven websites.

Thanks

dharam1987’s picture

Assigned: Unassigned » dharam1987
Status: Needs review » Reviewed & tested by the community

I have reviewed it and hereby confirms that this module is working fine.

lord_of_freaks’s picture

Thank you very much @dharam1987!!!

lord_of_freaks’s picture

Issue summary: View changes

Added PARview report

lord_of_freaks’s picture

Issue summary: View changes

Adding other project reviews

lord_of_freaks’s picture

Issue summary: View changes

New project revision

lord_of_freaks’s picture

Issue summary: View changes

Adding autofloat revision

lord_of_freaks’s picture

Issue tags: +PAreview: review bonus

Adding PARReview tag, as I have manually reviewed 3 project applications.

joseic’s picture

Hi,

I tested this module and looks right, working properly.

Good improvement!

Thanks @lord_of_freaks!

Enxebre’s picture

Hi,
module tested adding custom fields to profile2 entities and to my custom entities and everything works perfectly.

congrats for the work @lord_of_freaks

klausi’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +PAreview: single application approval

manual review:

  1. Ideally this project should be the 7.x branch of the existing CCK Required by role module, but I can see that the name does not make sense anymore. Please get in contact with the maintainer(s) because it seems they are also working on a 7.x version. So there should be a link to your module once this gets promoted.
  2. required_by_role_form_field_ui_field_edit_form_alter(): $title is unused, remove it.
  3. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project.

Thanks for your contribution, lord_of_freaks!

The project Required by role has been promoted to a full project: http://drupal.org/project/required_by_role

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

lord_of_freaks’s picture

Thank you very much @klausi, i commit all the changes and now it´s a full project ..

Just a little question ... can i become a git vetted user improving this module satisfying the current requirements (more han 120 lines of code or at least than 5 functions) or conversely i must send another module and go through a one-time approval process to get it?

Thanks in advanced, congrats for this great community service

klausi’s picture

Whenever you come up with a new project that does not exist yet create a new application and reference this application. Then it should be enough overall to approve you as git vetted user anyway.

lord_of_freaks’s picture

Thank you very mark @klausi ... next time maybe :-D until then ... then "the show must go on"

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Adding comment link to Review projects