Head

welcome,

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

automated review:

http://ventral.org/pareview/httpgitdrupalorgsandboxonemanonelaptop1655204git

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

.info file. Add:
configure = admin/appearance/advanced
to make the settings page accessible from the module list (operations column). See http://drupal.org/node/542202.

. module file line 141:
Dimension is known. Substitute ??x?? with 57x57.

.module file line 537:
Typo: anoother

Only minor issues reported, thus leaving status unaltered.

Your module is a good addition for modules like Metatag.

The coder module told me nothing bad about your code and the module works as expected.

Your code is ok, but please wrap all your descriptions in t() function (e.g. line 326).

I found a (really) small issue in your code. At line 123 there are two spaces between your <tr> and its class attribute.

At the and, create a new branch with the version number (e.g. 7.x-1.x) and remove your master branch.

Hi There,

Some nice features in here, a few comments and observations:

You haven't implemented _hook_uninstall() to clean up your variables [e.g.: 'head_settings'] set through variable_get calls in your .module file when a user un-installs your module.

The unknown sizes on the first two icons are actually 57x57

From the iOS docs:

For iPhone and iPod touch, create icons that measure:

• 57 x 57 pixels
• 114 x 114 pixels (high resolution)

For iPad, create icons that measure:

• 72 x 72 pixels
• 144 x 144 (high resolution)

You might consider placing a link to Apple's iOS developer documentation on creating application icons and artwork in your module so that users can get more information on how to create the right artwork:
http://developer.apple.com/library/ios/#documentation/userexperience/con...

The section on web clip icons is located here:
http://developer.apple.com/library/ios/#documentation/userexperience/con...

The description in the .info file "Meta Data for heads" doesn't really encapsulate the functionality of this module and could probably do with expanding. My suggestion would be a paraphrase of what you have in your README.txt file: "Provides a range of meta tags for controlling site appearance on mobile, linking artwork and icons, and IE specific settings such as site pinning."

Hi,

Unnecessary conditional statement (always true): Line 778

Typo: Line 689, cant -> can't

Typo: Line 942/955/970/984, Starup -> startup

Typo: Line 1236, dimsenions -> dimensions

Typo: Line 1239, and -> an

Thanks for your reviews, just make sure that you pick the oldest applications first. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/head.module
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   778 | ERROR | Whitespace found at end of line
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. Please add the differences to existing metatag modules to your project page. Example: http://drupal.org/project/metatag
2. "'#title' => 'Icons & Splash Screens',": all user facing text must run through t() for translation. Also in many other places, like the strings in the table markup.
3. head_settings(): why can't you use theme('table', ...) instead of the manual markup?
4. head_theme_settings_submit(): that function should be closer to the function that defines the form, i.e. immediately after it.

But that are not application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for more than a week, so ...

Thanks for your contribution, Rob Holmes!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.