Filter integration with wysiwyg

Hi claudinec,

Sorry for the slow/late reply but I have been very busy lately, mostly working on some other modules and couldn't find the time to give you an answer. I'm glad to hear I'm not the only one to find this feature interesting or useful.

I've added the module to sandbox: http://drupal.org/sandbox/DYdave/1818438
with all the necessary code so feel free to go ahead and checkout the module [See the version control tab if you need info on the branch and checkout instructions].

Everything should be explained on the project page and the usage of the module should be very straight forward.
Feedback, questions, comments and other contributions would be highly appreciated.

Last note, I'd still be glad to hear if collapse_text maintainers would be interested in adding this feature to the collapse_text module, as mentioned above. That would probably bring more leverage to get more compatibility across wysiwyg libraries (TinyMCE, CKEditor, etc...).

Thanks!

Thanks!
it works with cke4 ?

Hi claudinec and proweb.ua,

Sorry for this late reply, but I have started checking on that as soon as I received your messages (4 days ago).

Thanks very much proweb.ua for raising this: it brought to my attention the fact that there was work undergoing to provide support for newer versions of CKEditor... I haven't been following these developments that much and wasn't even aware that CKEditor 4 had a stable release.

Thanks very much claudinec for getting back to proweb.ua on that, I really appreciate your support and feedback.

So pretty much, the reason why I haven't replied yet is because I was waiting to see what was going on in:

• #1748268: CKEditor 4 beta and beyond
  Not really/completely relevant, since this one is related with the CKEditor module, which is different from WYSIWYG on which Collapse Text Wysiwyg is based and according to module's maintainer, it seems to be working fine, see: #1748268-7: CKEditor 4 beta and beyond. So I have been following this issue as well to see if we could get any inspiration from it for WYSIWYG.
• #1853550: Ckeditor 4.0 - The version of CKEditor could not be detected.
  This is probably the bulk of our issue here: CKEditor 4 support doesn't seem to be stable yet for WYSIWYG.
  I am now following this issue with a lot of interest to see if we could get any positive feedback on the support and in particular some patches have already been submitted (on which we would greatly appreciate your feedback for testing).
  So I haven't tested myself yet with CKEditor 4, but I would assume that if WYSIWYG still doesn't completely support it, then most likely some issues might happen with Collapse Text Wysiwyg.

As soon as I can see some positive feedback and stabilization of #1853550: Ckeditor 4.0 - The version of CKEditor could not be detected., then I will get that tested on Collapse Text Wysiwyg and get back to you with more information, whether:

• it needs work to fix some issues for compatibility
• or it's already compatible and doesn't need any additional debugging (personally, I have the feeling it should still be compatible if WYSIWYG support CKEditor 4)

In any case, you can be sure that I am following these issues very closely, went ahead and created an issue in Collapse Text Wysiwyg's tracker: #1890908: Support for CKEditor 4. I invite you to follow this issue so that you can get direct feedback if it is updated (for example, status changed to needs work, if there's any problem, or RTBC if anything is fine).

I would certainly greatly appreciate any of your feedback, testing, debugging, comments or questions on any of these tickets, that would greatly contribute to helping all of us moving forward.

Thanks again to all of you for your interest, time and feedback.
Cheers!

Thanks for the update, DYdave. I'll watch those issues about CKEditor 4 too, and try it out on a local dev environment.

Hi guys,

Following up with a support request at Collapse Text Wysiwyg, #1963958: Is this module going to end up being a full project, I wanted to get back to this issue and more particularly try to attract project maintainers' attention on this feature request.

Will this module end up being a full project or be rolled into the collapse text module.
The way it seems to be most times is that WYSIWYG support ends up in the input filter module itself.

It seems the Collapse Text Wysiwyg's code has been around for some time (more than 6 months) already, and tested by several users.
Perhaps we could consider having the sandbox integrated/merged to the Collapse Text module.

As an attempt to get the ball rolling, please find attached to this comment a patch against collapse_text-7.x-2.x at 5cd66c9, which merges the code from sandbox Collapse Text Wysiwyg and adds a new feature to the Collapse Text module to provide filter integration with CKEditor.
File attached as: collapse_text-filter-integration-wysiwyg-ckeditor-1793108-10.patch.

The image for the button couldn't be added to the patch, so after applying it, the attached png (button.png) file should be copied and renamed in the folder:
collapse_text/wysiwyg/ckeditor/button.png
(next to the new plugin.js file)

We would greatly appreciate if maintainers could potentially take a little bit of time to give us some feedback on whether this feature request could be acceptable/reasonable.

Feel free to let us know if you would have any questions, comments, objections, recommendations, suggestions or concerns on any aspects of this ticket or the attached patch, I would surely be glad to provide more information, explain in further details or re-roll the patch if necessary.

Any feedback, comments, testing, reviews, questions, suggestions, recommendations or objections would certainly be highly appreciated.
Thanks very much to all in advance.
Cheers!

@finedesign:

Thanks very much for your comment.

Will this resolve the issue where CKeditor disappears when Collapse Text is installed?

I'm afraid that's not really the purpose discussed in this feature request.
Patch from #10 adds a button to the CKEditor toolbar (through the Wysiwyg module hook/plugin system) to be more user friendly for editors when adding Collapse Text module's specific tags, for example: [collapse ....].
Therefore, if the editor is not displaying, such as for the case your described, this feature/patch wouldn't change much anyway.

For months now, the body field on every Edit page on a client site disappears because there is some conflict between CKeditor and Collapse Text.

This sounds like a different issue that I would assume should be posted in the corresponding modules (Collapse Text, Wysiwyg, or CKEditor if that's what you have been using), for the corresponding versions.
Additionally, I would recommend that you try looking in these modules' issue trackers, this might be an issue that could already have been resolved in a dev version or with an existing patch.

I hope I was able to answer your questions, but feel free to let us know if I missed or overlooked anything.
Cheers!

Wysiwyg 7.x-2.2+14-dev

CKEditor 4.1.1.5a2a7e3
CKEditor 4.1.0.80c139aa
CKEditor 4.0.3.0eafb700

Collapse Text 7.x-2.4+0-dev + path #10

after click OK, nothing happens

tested in last Opera, Firefox, Chrom and on two different websites and hosting