HTTP proxy

Welcome!

You need to set the status to "needs review" if you want to get a review. See http://drupal.org/node/532400

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

The only issue I can find right now is that most of the code exceeds the 80 characters-per-line limit, that will certainly hit an error in the PARreview.

Hi Devin,

It is written in a high standard as well.

Please notice two minor issues that should be addressed:
1. As vensires suggested, you should take a look at the automated report. There are some minor issues to take care of: http://ventral.org/pareview/httpgitdrupalorgsandboxdevincarlson1797030git
2. http_proxy_menu() uses string w/o locaulization. You should use $t = get_t() and $t('')

Greet work,

Moshe Kaplan
dSero. The Anti AdBlock Creators

dSero, can you explain #2 more? The hook_menu documentation defined both title and description as untranslated text, which seems to be what http_proxy_menu() is doing so I'm not sure what you're suggesting should change here.

If #2 isn't actually a problem, nothing in the automated review is a blocker, so I don't think this this should be "needs work."

Saving an empty string as the port number can break the operation as drupal_http_request() expects it to be either a number or not set. I'd suggest adding an element validator and amending the description so that someone who has cleared the field can restore at least the default value:

  $form['proxy_port'] = array(
    '#type' => 'textfield',
    '#title' => t('Port'),
    '#default_value' => variable_get('proxy_port', 8080),
    '#element_validate' => array('element_validate_integer_positive'),
    '#description' => t('The port number used by the proxy server for client connections (default: 8080).'),
  );

(there might of course be other ways to deal with this)

I also notice Chrome has an annoying tendency to prefill empty username and password fields with my credentials for the site itself, but there's no easy fix for that, and creating complex workarounds because of one not very smart browser isn't really the way to go.

Otherwise, it looks all good to me. There's not much code in this project, but as far as I've seen Devin's code in other modules, it was good, too.

Although this module on its own is a bit short to approve you your other work speaks for itself.

Thanks for your contribution, Devin Carlson!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.