clean up any code that is not to the Drupal specification

Beau Gunderson - October 1, 2007 - 17:24
Project:Markdown with SmartyPants
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I wanted to use Markdown with SmartyPants on a 6.x installation and so updated the code to make it compatible both with 6.x and with the Drupal code specification.

Attached is a patch.

AttachmentSize
marksmarty.10.01.patch3.21 KB

#1

Beau Gunderson - October 4, 2007 - 19:40
Category:task» bug report

#2

Beau Gunderson - October 4, 2007 - 19:41
Category:bug report» feature request

#3

greggles - January 19, 2008 - 19:49
Title:Update Markdown with SmartyPants for 6.x and clean up any code that is not to the Drupal specification» clean up any code that is not to the Drupal specification

I'm splitting this - there is a simple "update to 6" patch at http://drupal.org/node/208101.

Separately, I've created a new "cleanup" patch which has some benefits over this one
1) help works (note that when you changed _help to use $path you need to change the $in_section
2) It fixed some other php notices in the hook_help

I did this against HEAD which is also the branch point for 5.x so I it should apply to both.

AttachmentSize
cleanup_marksmarty.patch 4.4 KB

#4

moshe weitzman - January 22, 2008 - 21:17
Status:needs review» fixed

i cleaned up the versions listing on the filter configure page and then committed this. thanks.

#5

moshe weitzman - January 23, 2008 - 02:04

i cleaned up the versions listing on the filter configure page and then committed this. thanks.

#6

Anonymous (not verified) - February 6, 2008 - 02:12
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.