Panels Integration w/ argument handling

subscribing

+1

Panels2 is now beta. It'd be great if the maintainer could look into this patch now.

Subscribing hoping this module gets updated for Panels :)

Did you try the patch? Does it work like expected? Thanks.

Aha, now I understand what you were doing :-)

Some comments though:
1. Why not make:

+    if ($result = db_fetch_array(db_query("SELECT * FROM {panels_page} WHERE did = '%d'", $panel_id))) {
+      return array('type' => 'panels', 'ids' => array($result['did']));
+    }

part of _nodewords_detect_type_and_ids(). In fact, isn't that already part of this?

2. Then

+  /* Panels are tricky so lets do this */
+  if ($type = 'panels' && isset($ids)) {
+    $result = _nodewords_panels_load($ids);
+    $type = $result['type'];
+    $ids = $result['ids'];
+  }

doesn't seem needed.

3. The problem with the form ids that have changed is correct. Will fix that.

4. I suppose

+function nodewords_panels_pre_render($panel_id = NULL) {
+  $tags = nodewords_get('panels', $panel_id->did, TRUE);
+  foreach ($tags as $name => $content) {
+    if (!empty($content)) {
+      $argument = nodewords_get_arguments();
+      foreach ($argument as $key => $phrase) {
+        $content = str_replace('%'.$key, ucwords($argument[$key]), $content);
+      }
+      if($name != 'robots'){
+        drupal_set_html_head('<meta name="' . $name . '" content="' . $content . '" />');
+      }
+    }
+  }
+}

is a call for a hook of panels. But how is this going to work? Would one not have two occurences of the meta tags on panel pages?

I'd prefer some more general solution for arguments. Eg I suppose views also could have arguments. Maybe _nodewords_detect_type_and_ids() should return a array with 'type', 'ids' AND 'arguments'. In _nodewords_prepare() one could then do:

+      $argument = nodewords_get_arguments();
+      foreach ($argument as $key => $phrase) {
+        $content = str_replace('%'.$key, ucwords($argument[$key]), $content);
+      }

I'll look into this again tomorrow ... If my comments don't make sense, please tell me.

The argument part has not been added, the edit panel_pages part (form_ids etc) has.

Please test 5.x-1.8-rc1 and give feedback. Please test whether you can assign meta tags, whether they show up where you expect them to show up and whether, if you delete the panel, the tags are deleted too.

Once enough people test this, I can look at arguments.

Thanks!

Humm hey there I just added an meta info to a regular panel page and it does not seem to "save" the info, since when I check out the source, after clearing the cache, I can't see the meta info actually loading at all. It does work for views tho, but not for panel pages. It does not throw any error, but just does not seem to actually use the info I add there.

I just upgraded to panels beta4 so maybe that's why....

Patchak

Hi,
Is this panels-argument patch in metatags 1.9?

thanks in advance for your reply!

greetings,
Martijn

As the Drupal 5 version is not supported anymore, I am changing the status of this report.