Token i18n Macrons

You need to set the status to "needs review" if you want to get a review, see http://drupal.org/node/532400

Don't forget to add the "PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you will not show up on my high priority list.

A master branch still exists in git, and appears to be the default. This should be removed, per http://drupal.org/node/1127732

Module name is "token_i18n_macrons", but several functions use "token_i18n_macron" as a prefix, eg "token_i18n_macron_flatten()"

The switch in token_i18n_macron_flatten() should probably have a default case instead of the laundry-list at the top.

Switching status per comment #3.

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Review of the 7.x-1.x branch:

1. hook_token_i18n_macrons_dictionary_options_alter(): Please see http://drupal.org/node/1354#functions on how to document functions: missing @param tags.
2. token_i18n_macrons_help(): all user facing text must run through t() for translation.
3. "@param any $str": do not use "any", use "mixed" instead. Also elsewhere.

But that are not application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

token_i18n_macrons_help(): the problem is that you should not pass variables to t() where possible, because that cannot be found by automated translation extraction tools. Always pass string literals to t() where possible.

The Git commits are not connected to your user account. You need to specify an email address. See http://drupal.org/node/1022156 and http://drupal.org/node/1051722

But otherwise there were no objections for more than a week, so ...

Thanks for your contribution, superspring!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.