Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sandbox project page: http://drupal.org/sandbox/brunogoossens/1793476
I made this module to improve my staging process.
Reviews are welcome.
Other module reviews:
Node Reference Selector Widget : http://drupal.org/node/1437126#comment-6034962
Facebook Comments Administration: http://drupal.org/node/1535574#comment-6035054
Comment | File | Size | Author |
---|---|---|---|
#6 | Action name problem | 29.8 KB | tomasbarej |
Comments
Comment #1
tdurren CreditAttribution: tdurren commentedYou need to fix comments
1) Admin deploy overeview. => overview
2) Tcheck if user can perform a deploy.
3) Tcheck if they have access to the edit admin page.
4) easely
Dont know whether watchdog messages should be wrapped with t()
e.g. watchdog('deploy', 'Backup files created');
Need PHPDoc for all functions
isset($form_state['values']['machine_name']) &&
!empty($form_state['values']['machine_name'])
!empty more strict so there is no need to use both
I installed the module and as soon as I opened the settings I got
Notice: Undefined variable: $rows in deploy_actions_admin_overview()
(line 75 of /var/www/tinypass.local/drupal7/modules/deploy_actions/deploy_actions.admin.inc).
Comment #2
brunogoossens CreditAttribution: brunogoossens commentedChanged all the above issues. The module is ready for a new review.
Comment #3
brunogoossens CreditAttribution: brunogoossens commentedComment #4
monymirzaHi,
there is a little bit work required. Please fix errors and warnings listed here: http://ventral.org/pareview/httpgitdrupalorgsandboxbrunogoossens1793476git
Run coder module to check your code before pushing to git
(please check the Drupal coding standards)
Comment #5
brunogoossens CreditAttribution: brunogoossens commentedFixed the minor coder issues.
The module is ready for a full review.
Comment #6
tomasbarej CreditAttribution: tomasbarej commentedHi brunogoossens,
Really nice module, here is my feedback.
Automatic review: as you said no issues.
Manual review:
ethe deployconfigure = admin/config/system/deploy-actions
Comment #7
brunogoossens CreditAttribution: brunogoossens commentedAlso e-mail him about the deploy name problem because I can't reproduce it.
The module is ready for a other full review.
Comment #8
klausiWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #9
klausiSorry for the delay. Make sure to review more project applications and get a review bonus and this will get finished faster.
manual review:
require_once 'mymodule.inc';
Comment #10
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #10.0
PA robot CreditAttribution: PA robot commentedAdding reviews