Download & Extend
Date » Issues

Date showing on node view - not showing on node edit - PHP 5.4 issue

Posted by ptitwolfy on October 10, 2012 at 9:19am
Project:Date
Version:6.x-2.x-dev
Component:Date Popup
Category:bug report
Priority:normal
Assigned:MEGAWATT
Status:needs review

Issue Summary

Hi there,

Here is my issue: I can create a node containing a date (popup widget) and save it, the date will appear on the node view. If I want to get back to the editing, the date is empty.

Everything was working fine under PHP 5.3, now that my server is running PHP 5.4 I have the same issue for several websites. Running the same website on a PHP 5.3 localhost will make everything work again...

Not sure if related, seems to be the same issue for other modules:
http://drupal.org/node/1159880
http://drupal.org/node/1453570

Any ideas???

Thanks

Login or register to post comments

Comments

#1

Posted by jackalyst on October 10, 2012 at 5:41pm

This is my exact same issue.

In my logs I get "Illegal string offset 'month' in /.../includes/form.inc on line 1345"

Same error applies for second, hour, day, year...

#2

Posted by ptitwolfy on October 15, 2012 at 3:23pm

Anyone else with same the issue? Any ideas how to fix it?
Thanks

#3

Posted by MEGAWATT on October 16, 2012 at 11:17am

use this to fix 1345 http://drupalcontrib.org/api/drupal/contributions%21date%21date_popup%21...
but it do not fix echo date time and time

#4

Posted by MEGAWATT on October 17, 2012 at 7:46am
Assigned to:Anonymous» MEGAWATT

how to looks date and time in page node edit , drupal 6, php 5.4.6
do this:
1st of all fix you code similarity http://drupalcontrib.org/api/drupal/contributions%21date%21date_popup%21...

all changes in date/date_popup/date_popup.module

1. in function date_popup_process_date change

<?php
'#default_value' =>(!empty($element['#value']['date']) || !empty($edit['date'])) && is_object($date) ? date_format_date($date, 'custom', $date_format) : '',
?>

change to
<?php
date_format_date($date, 'custom', $date_format) ,
?>

next step
<?php
<code>if (!empty($element[&#039;#force_value&#039;])) {$sub_element[&#039;#value&#039;] = $sub_element[&#039;#default_value&#039;]; }</code>
?>

change to
<?php
$sub_element['#value'] = $sub_element['#default_value'];
?>

2. in function date_popup_process_time change

<?php
 
'#default_value' =>(!empty($element['#value']['time']) || !empty($edit['time'])) && is_object($date) ? date_format_date($date, 'custom', $time_format) : '',

?>

change to
<?php
date_format_date($date, 'custom', $time_format) ,
?>

and
<?php
if (!empty($element['#force_value'])) {$sub_element['#value'] = $sub_element['#default_value']; }
?>

change to
<?php
$sub_element['#value'] = $sub_element['#default_value'];.
?>

#5

Posted by ptitwolfy on October 17, 2012 at 9:00am

Thanks so much, it's working perfectly now!

#6

Posted by indydas on October 25, 2012 at 9:45pm

This fix didn't work for me. When I use date and time too after a content type import the dates and times are empty.

#7

Posted by nicob on January 4, 2013 at 1:55pm

Subscribing [#4] fixes the problem for me, actually just taking out the conditional

(!empty($element['#value']['time']) || !empty($edit['time'])) && is_object($date) ?

works like a charm :)

Interesting thing,
$element['#value'] = "2013-01-01";

In PHP 5.3:
empty($element['#value']['date']) ? => true

PHP 5.4:
empty($element['#value']['date']) ? => false

Thanks!

#8

Posted by bkat on January 26, 2013 at 2:37am

All you need to do is remove the ['time'] from $element['#value']['time'] in date_popup_process_date and date_popup_process_time

Works for me in php 5.4.10 and 5.2.17.

Patch included -- built against 6.x-2.9+6-dev

AttachmentSizeStatusTest resultOperations
date_popup.module.patch1.18 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch date_popup.module.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test

#9

Posted by GreenSkunk on January 28, 2013 at 5:01pm

After upgrading to PHP 5.4.10 from PHP 5.2.x, I had the issue when editing the date fields that used the date popup were empty. Patched 2 sites Drupal 6 sites running on PHP 5.4.10 and date fields are populated again.

Others please review and test.

Thank you fellow Drupalers!

#10

Posted by TajinderSingh on February 3, 2013 at 1:26pm

#8 works perfect.

#11

Posted by rterrero on February 6, 2013 at 12:50pm

#8 works perfect for me too!

#12

Posted by powery on February 22, 2013 at 1:19pm

#8 works fo me, please send it to the dev version

#13

Posted by ryan_courtnage on February 28, 2013 at 12:38am
Status:active» reviewed & tested by the community

#8 working here

#14

Posted by System Message on February 28, 2013 at 1:48am
Status:reviewed & tested by the community» needs work

The last submitted patch, date_popup.module.patch, failed testing.

#15

Posted by arlinsandbulte on March 2, 2013 at 12:27pm
Status:needs work» needs review

#8: date_popup.module.patch queued for re-testing.

#16

Posted by System Message on March 2, 2013 at 12:30pm
Status:needs review» needs work

The last submitted patch, date_popup.module.patch, failed testing.

#17

Posted by NaX on March 15, 2013 at 8:26am

#8 Worked for me, thanks.

#18

Posted by ice5nake on March 19, 2013 at 6:27pm

Patch worked for me.

I had to use the patch command without the -p1 to get it to work for me.

I've seen patches sit in "needs work" because of a failed test more than once.

It'd guess the test failed because the test uses the -p1 option

git apply --check -p1 /var/lib/drupaltestbot/sites/default/files/review/date_popup.module.patch

#19

Posted by mikeytown2 on March 22, 2013 at 6:10pm
Version:6.x-2.9» 6.x-2.x-dev
Status:needs work» needs review

Rerolled #8

Adding in text for search purposes

Warning: Illegal string offset 'year' in _form_set_value() (line 1345 of includes/form.inc).
Warning: Illegal string offset 'month' in _form_set_value() (line 1345 of includes/form.inc).
Warning: Illegal string offset 'day' in _form_set_value() (line 1345 of includes/form.inc).
Warning: Illegal string offset 'hour' in _form_set_value() (line 1345 of includes/form.inc).
Warning: Illegal string offset 'minute' in _form_set_value() (line 1345 of includes/form.inc).
Warning: Illegal string offset 'second' in _form_set_value() (line 1345 of includes/form.inc).

AttachmentSizeStatusTest resultOperations
date_popup-1808416-19-php5.4.patch1.37 KBTest request sentNoneView details

#20

Posted by kerasai on April 13, 2013 at 3:26am

#19 applied cleanly to 6.x-2.9 for me and allowed the date values to render on node edit screens.

+1 RTBC

#21

Posted by kerasai on April 13, 2013 at 3:59am

densolis assisted me to find out that the test is not running due to the 6.x-2.x branch not passing testing. In order to move forward either the patch need to be manually reviewed or a maintainer needs to fix up the branch so the patch can be automatically tested.