The Swift Pics module makes adding large photo galleries very fast and easy. It simply scans and imports the image files from a folder directory in sites/default/files and automatically adds them to an image field to be used as you wish.

I created this because I was simply tired of having to select/upload images one at a time for photo galleries I create which can have hundreds of photos in them. All that is required is that you have file server (FTP, SSH, etc.) access to place the files in a folder in your sites/default/files directory.

The Swift Pics module adds a Swift Pics content type which has the ability to scan a file directory in sites/default/files for any image types and adds them all to an image field in the gallery node. The images are added as true Drupal managed image/file types and to the multi-value Image field of the Swift Pics node.

Project Page: http://drupal.org/sandbox/deviantpixel/1784794
Git Link: http://drupalcode.org/sandbox/deviantpixel/1784794.git
Module for: Drupal 7.

Comments

kholloway’s picture

kholloway commented

Just a note:
I actively use and test the module on my production site http://deviantpixels.com and it works great (:

cubeinspire’s picture

cubeinspire commented

Hi deviantpixel and thank you for sharing this module,

PAReview: Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
PAReview: major coding standards / best practice issues by pareview.sh / drupalcs
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxdeviantpixel1784794git.

Other problems: image load problems
image_load() can return FALSE if there was a problem loading the image, it would be better to check the return of this function before accessing the result attributes. Line 59 of swift_pics.module.
Other problems:image style thumbnail
The view uses the image_style thumbnail, this could not exist on other Drupal installations.
You should not relay on the fact that this exists. You could check the existing image styles using image_styles(). See: http://api.drupal.org/api/drupal/modules!image!image.module/function/ima...

Regards,

Sergio

cubeinspire’s picture

cubeinspire commented
Status: Needs review » Needs work

needs work

kholloway’s picture

kholloway commented

Sounds great. I'll work on these (:

Thanks

kholloway’s picture

kholloway commented
Status: Needs work » Needs review

I corrected the 3 issues above.

If the thumbnail image style doesn't exist, it is created before the default view is added.

The code scan issues were resolved.

I check the image load now to make sure there wasn't problems loading it.

Thank you and let me know if any other issues are found.

aritra.ghosh’s picture

aritra.ghosh commented

Hii,

I installed the module and it seems to work nicely. kudos for such a nice module.

However there are some indentation and coding style issues as pointed out by Automatic Code review tool.
http://ventral.org/pareview/httpgitdrupalorgsandboxdeviantpixel1784794git

Also, there is still a master branch make sure to take necessary actions. Please refer to the output of the above link for directions.

Otherwise looks like RTBC to me.

Thanks,
Aritra.

aritra.ghosh’s picture

aritra.ghosh commented
Status: Needs review » Needs work

I am changing the status to needs work for you to fix the minor issues.

kholloway’s picture

kholloway commented
Status: Needs work » Needs review

All code scan fixes were done and the master branch was deleted.

Thanks for your previous review and let me know if anything else is needed.

cubeinspire’s picture

cubeinspire commented

Code style issues are not considered as blockers, it's important to point them out and corrected them but status should stay on need review if there is no blocker issue.

lyricnz’s picture

lyricnz commented

Q: how is this module different to http://drupal.org/project/imagefield_import ? (which is in need of a D7 version)

Have you looked at http://groups.drupal.org/node/155764

kholloway’s picture

kholloway commented

I actually didn't know about imagefield_import. It is close to that except it is geared towards image media only as opposed to file import. Besides that there are a lot of similarities. Of course this being a D6 solution I didn't find this before for my needs which is why I developed this module.

As for the others in the second link some are close but are a bit more geared to batch migration than normal content creation it seems. I've tried every option I could find and making this module was the only thing that worked for me. Hopefully it can be useful to someone else trying to do the same thing.

kholloway’s picture

kholloway commented

Guess I should have asked but is there something more I need to do? This is my first time going through this process so I'm not sure if I'm supposed to change the status of this now that the review appears to be done.

Thanks

stborchert’s picture

stborchert
he/him
Primary language German
commented

We are currently quite busy with all the project applications so it would be great if you can review some other project applications and get some review bonus.
If you have reviewed 3 other applications add the links to your comments to the main description of this issue and add the tag "PAReview: Bonus".

trogels’s picture

trogels commented

Hi,

Cool module. I know it's nitpicking, but I'm trying to get the review bonus. :)

swift_pics.module
- The switch is not really necessary in function swift_pics_node_validate
- Instead of accessing entity properties like this: $node->swift_pics_path[$node->language][0]['value'] you could look into entity_metadata_wrapper http://drupal.org/node/1021556
- On line 65 the string $drupal_error_message should not use concatenated strings like this. the string should be using the replacement tags ie. %file or !file and then the t function should have an array with %file => $file->uri as the second parameter.

h3rj4n’s picture

h3rj4n commented
Status: Needs review » Needs work

Don't forget to set it to 'needs work'.

kholloway’s picture

kholloway commented

I'll look at these reported suggestions and get them added.

ankitchauhan’s picture

ankitchauhan commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications. Get a review bonus and help us reviewing and I'll take a look at your project right away :-)

kholloway’s picture

kholloway commented
Status: Closed (won't fix) » Needs review

The suggests asked above were done. I did these though it was noted that these were (nice to have) changes and not terribly required. I did do them though because they were nice suggestions.

The exception is that entity_metadata_wrapper is great if I'm using and relying on the entity API module which I'm not so I didn't do that suggestion. The others are done.

I am willing to review other modules to get this moved along as a module faster since it's been being reviewed for a long time now. I'm not sure if there is possibly anything further I can change on this so hopefully all is satisfied and this can be approved (it's very small/non-complex).

Let me know if there are any questions/concerns.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, that's one of the best README.txt files I've seen yet! If this module is similar to imagefield_import, you may want to work on making this the "official" D7 version, either by combining code or adding a link from their project page to yours.

kholloway’s picture

kholloway commented

Good point. I'll keep that in mind after this is accepted (:

I guess next is the waiting game for this to be switched to be a public module.

Thanks

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Title: Swift Pics » [D7] Swift Pics
Status: Reviewed & tested by the community » Fixed

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

That being said, I think this module is different enough as it is now.

Thanks for your contribution, deviantpixel!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.