Flush is a module for Drupal 7.x that provides an easy way to clear the system cache. The module gives admins (or whoever is given permission) the ability to use CTRL+ALT+F to clear cache. It's been so far useful in my applications and maybe it can be of use to the community. Thanks folks!

Sandbox Page: http://drupal.org/sandbox/brianjamesward/1820014
Sandbox Git: brianjamesward@git.drupal.org:sandbox/brianjamesward/1820014.git
Github Clone: https://github.com/brianjamesward/flush.git

CommentFileSizeAuthor
#16 patch.txt493 bytesbhosmer
#7 patch.txt420 bytesbhosmer

Comments

briward’s picture

briward commented
Issue summary: View changes

Adding clone URL

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Please follow http://drupal.org/node/1011698 and create a sandbox on drupal.org.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

briward’s picture

briward commented

Thanks Klausi, I'll do my best to try help out.

briward’s picture

briward commented
Issue summary: View changes

Add github clone url.

briward’s picture

briward commented
Status: Needs work » Needs review

Created a sandbox for the project and provided it's url and git url.

grisendo’s picture

grisendo commented

You have some validation errors:

You can use that online tool, it's very useful.

Please, fix them, ask if you have any questions.

developmenticon’s picture

developmenticon commented

Hi,

General

  • Remove .gitattributes and .gitignore file from the module folder
  • There is a readme.md file, rename to README.txt

flush.info

  • The files defined in the files[] directive are not required, you should remove them

flush.module

I hope it helps you a bit!

briward’s picture

briward commented

Thanks for your comments and reviews guys. I've updated and fixed all standard's issues but unfortunately yes, the code may not be 120 codes long but it's a very simple module. I understand this may mean it will not be submitted but hopefully this is not the case.

Please use the dev branch now (7.x-dev) as your branch for testing/reviewing. Once and if the module is submitted it will be switched to the 7.x-1.0 branch.

Cheers.

briward’s picture

briward commented
Issue summary: View changes

Add sandbox url.

bhosmer’s picture

bhosmer commented
Status: Needs review » Needs work
StatusFileSize
new patch.txt420 bytes

You need to change your js on line 17:

window.location = 'admin/flush/run';

When I use ctrl-alt-f, I get a 404

I did something very similar a while back: http://drupal.org/sandbox/bhosmer/1170266

But my application was denied: http://drupal.org/node/1170924

Maybe you'll have better luck.

briward’s picture

briward commented

Thanks for the review, it requires clean URLs to function properly. Did you have these enabled?

bhosmer’s picture

bhosmer commented

Yes, I had clean urls enabled.

briward’s picture

briward commented
Status: Needs work » Needs review

Thanks bhosmer, that's the URL fixed on the dev branch (7.x-dev).

bhosmer’s picture

bhosmer commented
Status: Needs review » Reviewed & tested by the community

Cool and nice job. It works as designed!

I've added feature request to your issue que: http://drupal.org/node/1822990

briward’s picture

briward commented

Thanks very much for reviewing my project. I'll be working on new features as requested on it's issues page in the near future which will feature in the next version up.

briward’s picture

briward commented
Issue summary: View changes

Redo text for address

bhosmer’s picture

bhosmer commented
Status: Reviewed & tested by the community » Needs work

I was a bit hasty in my RTBC, it seems there are still some issues with the JS redirect.

briward’s picture

briward commented

Hey Bhosmer, on the javascript "window.location" issue, could you possibly send me the URL of your 404 you receive when you run the flush function? Also, which browser was your problem occurring on? Thanks.

bhosmer’s picture

bhosmer commented

Your latest from 7.x-1.0 295c6289 sends me to 295c6289

This is using Chrome and Firefox.

bhosmer’s picture

bhosmer commented
StatusFileSize
new patch.txt493 bytes

Hey check this out! I asked a javascript guy I work with and we came up with this patch. Try it out and see what you think.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Added permissions config point to blurb.