Drupal.org
Issues

Flush

Posted by brianward on October 22, 2012 at 6:50pm
Project:Drupal.org Project applications
Component:module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

Flush is a module for Drupal 7.x that provides an easy way to clear the system cache. The module gives admins (or whoever is given permission) the ability to use CTRL+ALT+F to clear cache. It's been so far useful in my applications and maybe it can be of use to the community. Thanks folks!

Sandbox Page: http://drupal.org/sandbox/brianjamesward/1820014
Sandbox Git: brianjamesward@git.drupal.org:sandbox/brianjamesward/1820014.git
Github Clone: https://github.com/brianjamesward/flush.git

Login or register to post comments

Comments

#1

Posted by klausi on October 22, 2012 at 7:37pm
Status:needs review» needs work

Please follow http://drupal.org/node/1011698 and create a sandbox on drupal.org.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

#2

Posted by brianward on October 22, 2012 at 8:02pm

Thanks Klausi, I'll do my best to try help out.

#3

Posted by brianward on October 23, 2012 at 8:40am
Status:needs work» needs review

Created a sandbox for the project and provided it's url and git url.

#4

Posted by grisendo on October 23, 2012 at 9:45am

You have some validation errors:

You can use that online tool, it's very useful.

Please, fix them, ask if you have any questions.

#5

Posted by developmenticon on October 23, 2012 at 11:38am

Hi,

General

  • Remove .gitattributes and .gitignore file from the module folder
  • There is a readme.md file, rename to README.txt

flush.info

  • The files defined in the files[] directive are not required, you should remove them

flush.module

I hope it helps you a bit!

#6

Posted by brianward on October 23, 2012 at 12:38pm

Thanks for your comments and reviews guys. I've updated and fixed all standard's issues but unfortunately yes, the code may not be 120 codes long but it's a very simple module. I understand this may mean it will not be submitted but hopefully this is not the case.

Please use the dev branch now (7.x-dev) as your branch for testing/reviewing. Once and if the module is submitted it will be switched to the 7.x-1.0 branch.

Cheers.

#7

Posted by bhosmer on October 23, 2012 at 3:46pm
Status:needs review» needs work

You need to change your js on line 17:

window.location = 'admin/flush/run';

When I use ctrl-alt-f, I get a 404

I did something very similar a while back: http://drupal.org/sandbox/bhosmer/1170266

But my application was denied: http://drupal.org/node/1170924

Maybe you'll have better luck.

AttachmentSize
patch.txt 420 bytes

#8

Posted by brianward on October 24, 2012 at 8:18am

Thanks for the review, it requires clean URLs to function properly. Did you have these enabled?

#9

Posted by bhosmer on October 24, 2012 at 11:26am

Yes, I had clean urls enabled.

#10

Posted by brianward on October 24, 2012 at 8:01pm
Status:needs work» needs review

Thanks bhosmer, that's the URL fixed on the dev branch (7.x-dev).

#11

Posted by bhosmer on October 25, 2012 at 2:00pm
Status:needs review» reviewed & tested by the community

Cool and nice job. It works as designed!

I've added feature request to your issue que: http://drupal.org/node/1822990

#12

Posted by brianward on October 25, 2012 at 3:32pm

Thanks very much for reviewing my project. I'll be working on new features as requested on it's issues page in the near future which will feature in the next version up.

#13

Posted by bhosmer on October 25, 2012 at 7:38pm
Status:reviewed & tested by the community» needs work

I was a bit hasty in my RTBC, it seems there are still some issues with the JS redirect.

#14

Posted by brianward on October 26, 2012 at 8:19am

Hey Bhosmer, on the javascript "window.location" issue, could you possibly send me the URL of your 404 you receive when you run the flush function? Also, which browser was your problem occurring on? Thanks.

#15

Posted by bhosmer on October 26, 2012 at 12:34pm

Your latest from 7.x-1.0 295c6289 sends me to 295c6289

This is using Chrome and Firefox.

#16

Posted by bhosmer on October 26, 2012 at 12:56pm

Hey check this out! I asked a javascript guy I work with and we came up with this patch. Try it out and see what you think.

AttachmentSize
patch.txt 493 bytes

#17

Posted by klausi on January 18, 2013 at 12:23pm
Status:needs work» closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

nobody click here