Closed (fixed)
Project:
AdaptiveTheme
Version:
7.x-3.x-dev
Component:
CSS/HTML
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2012 at 20:47 UTC
Updated:
4 Feb 2014 at 15:00 UTC
Jump to comment: Most recent
Comments
Comment #1
Jeff Burnz commentedComment #2
katannshaw commentedI was able to reproduce this same error by following the steps from the AT documentation on templates. This is what it says:
So like smhanes on the original post, I did the following:
Which resulted in this error:
Notice: Undefined index: leaderboard in include() (line 104 of \mysite\sites\all\themes\adaptivetheme\at_core\templates\page--full-width-wrappers.tpl.php).I've also found these similar issue reports but there doesn't appear to be a solution with the UI as of yet:
Comment #3
katannshaw commented@Jeff Burnz: Has there been any update on this issue? It's still happening for me, so I cannot use the 100% width option.
Comment #4
Jeff Burnz commentedAt this stage I have to "not fix" this bug, instead in the latest dev the option to use full width wrappers is now disabled (completely removed for this theme).
The main reason is this - many themes are not designed to work will full width heades, footers etc, PR is one of those themes, the main header image is a fixed size image, stretching it etc looks bad, also it's a lot of additional work to make that option work in many themes (images are just one of the issues).
The setting was envisioned for use on new themes, for example if you're building one from AT Subtheme, it was short sighted of me to not think that people would expect it to work with existing themes like PR, Sky, Corolla, however it will never work with those themes.
Therefor I have to set this to won't fix, and the real fix is to disable this option in themes that really cannot support it, or where it's just too much work.
I really do apologies for taking a year a to answer this, I have been away for the best part of two years due to illness and have only been able to give sporadic support to these projects.
Comment #5
Jeff Burnz commentedSorry, setting status.
Comment #6
katannshaw commentedI really appreciate the quick and thorough response to my #3 post, and it makes a lot of sense. It's a great theme regardless so it will work for me. Good luck to you with the illness stuff, and let me know if you'd ever like for me to test things out against my install in the future.
Comment #7
Jeff Burnz commentedI'm going to fix this after all, too many issues and conceptually a bad idea to start with:
We need to use this in theme settings to remove the option, note to self to do this for ALL sub themes that cannot support this feature:
Comment #8
Jeff Burnz commentedOK, this should be fixed in all sub theme dev versions.
Comment #9
katannshaw commentedI've made this change on my install. Thanks Jeff.