As I read in this post http://drupal.org/node/1011698 sandbox to full project. I'm in this step.

Fine Uploader for Drupal 6

Allow you upload mass files at once. Integration with the library fine uploader Browser support (as say the developer) IE7+, Firefox, Safari (OS X), Chrome. It does not use Flash, jQuery or any external libraries (we need only the fine uploader library). Is an alternative for Drupal 6 for mass upload files.

How it works

Uses an XMLHttpRequest(AJAX) for uploading multiple files with a progress-bar.

Requiered

fine uploader
cck
filefield
imagefield
imagecache *optional

Installation.

Download the last fine uploader [https://github.com/valums/file-uploader/wiki/Releases] release
Place it into sites/all/libraries/fine_uploader folder
Download and active this module
Setup permision in admin/user/permissions
Go into some content type and edit a field with image option and select de widget fine uploader
And its done upload some files and try it.

Proyect link: http://drupal.org/sandbox/killua99/1825890
Repository link: http://drupalcode.org/sandbox/killua99/1825890.git

Others links from project in my hands. http://drupal.org/project/twitter_queue

Comments

killua99’s picture

killua99 commented
Issue summary: View changes

Updated issue summary.

vineet.osscube’s picture

vineet.osscube commented

Hi,
I suggest you to take a look at this page:

http://ventral.org/pareview/httpgitdrupalorgsandboxkillua991825890git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

killua99’s picture

killua99 commented

And what you mean "errors" I mean the code works I have in deploy this module in my company and its working without a notice.

Other modules don't pass that test also and they're public and full proyect.

So please take a look http://ventral.org/pareview/httpgitdrupalorgsandboxkillua991825890git

I did some work to "fix that errors" I did not "solve" all of them cause its none trivial think.

killua99’s picture

killua99 commented
Issue summary: View changes

Updated issue summary.

killua99’s picture

killua99 commented
Issue tags: +PAreview: review bonus

I'm trying to get a good code and get this project to live. Help me with this :)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue tags: -PAreview: review bonus

Removing review bonus tag, you need to list 3 manual review links in the issue summary as indicated in #1410826: [META] Review bonus.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Updated issue summary.

killua99’s picture

killua99 commented

Ok I just have two errors.

FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/fine_uploader.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
111 | ERROR | Using the e flag in preg_match is a possible security risk. For
| | details see http://drupal.org/node/750148
117 | ERROR | Using the e flag in preg_replace is a possible security risk.
| | For details see http://drupal.org/node/750148
--------------------------------------------------------------------------------

How I can fix them?

killua99’s picture

killua99 commented

It's seem a full clean Drupal's standard now only need some reviews.

http://ventral.org/pareview/httpgitdrupalorgsandboxkillua991825890git

Thanks.

bryanbraun’s picture

bryanbraun commented
Status: Needs review » Reviewed & tested by the community

I tested it out and it worked as expected. It passed all automated code tests. From the manual code check:

  • Git Repo was set up properly
  • The developer showed an understanding of Drupal functions and APIs.
  • Used check_plain and other form validation for all user input.
  • Used t() function for all strings.
  • Code commenting was sufficient
  • Documentation (on project page and README.txt) was brief but sufficient for setting up and using the module
  • Admittedly, I'm not a security expert, but I couldn't find any blatant security violations.

Unless somebody else finds something wrong, I'm calling it good and setting to RTBC.

killua99’s picture

killua99 commented

Thanks bryanbraun!

jthorson’s picture

jthorson commented
Status: Reviewed & tested by the community » Fixed

Comments:

.install file
Line 31: This line would be a mouthful to translate ... splitting it into multiple concatenated $t() strings might simplify things. Also, ensure that the string inside the $t() function aligns with the recommendations at http://drupal.org/node/322774.
.module file
fine_uploader_init(): Are the css files required on every page load? For performance reasons, it may be beneficial to add a check which restricts this to edit pages, as an example.
Line 91: 'fine_upolader_item' typo.
Line 194/198: I would feel better if the $id_class variable was run through check_plain() before being directly concatenated into the #prefix. #prefix/#suffix should contain only the sanitized version of any user-generated input (whether generated inside or outside of your module). In this specific case, it's not strictly required ... since the field name that this variable is derived from only allows lowercase letters, underscores, and dashes.

None of the above are showstoppers, so ...

Thanks for your contribution, killua99!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

killua99’s picture

killua99 commented

Thanks for you advice, I apply this I good to know better CS.

So this is it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Removing reviews options