In-App Purchases

Hi,

Here is the list your issues after manual review.

1) Please make sure each of your module file ends with a new line.
2) Also bit of formatting issues in your module file. Please make sure your follow drupal coding and formatting here. Example : In your hook_menu function.
3) In your iap_apple module file : Make sure you follow proper doxygen commenting. Format should be : -

/**
* Implements hook_requiredhook().
*/

Also fix your ventral issues here : http://ventral.org/pareview/httpgitdrupalorgsandboxalexsorokinv1815858git

(This is my first review - if anyone else would like to comment I'd appreciate it)

Hi,

PAReview looks much cleaner now. I can see your readme file shows some errors - it looks like the PAReview tool is mistaking your opening <?XML tag for a PHP opening tag. As for the line exceeds 80 characters errors I can see you have JSON requests/responses - you could probably wrap onto new lines after :'s and ,'s but I wouldn't say it's a major issue.

The previously mentioned issues appear to be resolved, and I don't see anything particularly bad with the code. One suggestion I could make is your project page looks a bit empty - have a look at the tips for a great project page.

On further review of the code, I spotted you define a settings page at admin/config/system/iap/default. However, the callback for that page creates a form with no editable settings. Is this code required?

Also, you may want to set the configure attribute in your .info file:

http://www.drupalcoder.com/blog/configure-links-on-modules-overview-page...

Pushing to needs work (unless you're planning to add further settings at admin/config/system/iap/default)

Hi Alex,

Your code changes look good to me. However, it appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch:

http://drupal.org/node/1127732

Looks good to me - pushing to RBTC. Please let me know if I've missed anything in my review.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

Changed Git clone command

manual review:

1. iap_help(): the module does not specify that path?
2. Why are there 2 modules? iap.module does not do anything?
3. iap_apple_install(): no need to set variables on installation, as you can use default values with variable_get() anyway.
4. iap_apple_main_settings(): you could use system_settings_form() then you don't need to write the submit handler yourself.
5. _iap_apple_services_verify(): doc block is wrong? $data is an array? For stdClass objects use "object" instead of "obj".

But that are not application blockers, so ...

Thanks for your contribution, alex.sorokin.v!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Just leave issue at "fixed", they will close automatically after 2 weeks.