The Project aims at integrating Netcore as a SMS Gateway for SMS Framework.

Netcore provides SMS Services in India and hence the coverage is specific to India Only, but can be extended if needed.

Current Status:

*The Module have been tested with sms_user, sms_bulk, SMS List

Dependency:
SMS Framework

Project Page Link : Netcore SMS Gateway

Link for my git repository : git clone --recursive --branch master darshanc@git.drupal.org:sandbox/darshanc/1827808.git netcore_sms_gateway

Netcore SMS Gateway is a Drupal 6 project

Comments

gazoakley’s picture

Status: Active » Needs work

Hi darshanchoudhary,

Thanks for submitting a project application for review. To help you track the status of your application you might want to enable email notifications for changes to your application:

http://drupal.org/project/issues/subscribe-mail/projectapplications

You might also want to participate in the review bonus program - this should help ensure your application is review quickly:

http://drupal.org/node/1410826

The PAReview tool identified a few issues which need addressing:

http://ventral.org/pareview/httpgitdrupalorgsandboxdarshanc1827808git

  • It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
     
  • README.txt is missing, see the guidelines for in-project documentation.
     
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
     
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
     
  • Remove "project" from the info file, it will be added by drupal.org packaging automatically.
     
  • Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically.
     
  • Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
    ./netcore_sms_gateway.info:   ASCII English text, with CRLF line terminators
    netcore_sms_gateway.info
    netcore_sms_gateway.module
    
  • Remove all old CVS $Id tags, they are not needed anymore.
    netcore_sms_gateway.info:1:; $Id: netcore_sms_gateway.info,v 1.2 2010/07/20 15:57:54 abhisheknagar Exp $ 
    netcore_sms_gateway.module:2:// $Id: netcore_sms_gateway.module,v 1.1 2010/07/20 15:50:03 abhisheknagar Exp $ 
    README:1:$Id
    
  • Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). Please see the above link for further information.
     

Please check/fix these issues before changing the status back to "needs review"

gazoakley’s picture

It appears that there have been multiple project applications opened under your username:

Netcore SMS Gateway: http://drupal.org/node/1847550
Ubercart Ajax Attributes List Price Calculations: http://drupal.org/node/1847616

As successful completion of the project application process results in the applicant being granted the ´Create Full Projects´ permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as ´closed(duplicate)´, with only the oldest application left open.

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the ´open´ application as a duplicate, and re-open one of the project applications which had been closed.

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

Issue summary: View changes

Project page link added and i want mark the status as needs review but not able to do so.