Taxonomy Publisher Filter

Hi,
you need to move the project into a version branch.
See the docs here: http://drupal.org/empty-git-master
I will also do a code review once you're done

you can also remove the project page link form your project page

Hi balintcsaba,

Just a quick heads up on code review.
It seems your code has a few issues reported from the Automatic Review system:

Automated Review: http://ventral.org/pareview/httpgitdrupalorgsandboxbalintcsaba1857296git

Review of the master branch:

Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project.

FILE: .../modules/pareview_temp/test_candidate/taxonomy_publisher_filter.api.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
64 | ERROR | Last parameter comment requires a blank newline after it
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service


I recommend you also try to run this validation again, after you have made the changes suggested by reszli in #1, related with the GIT Branch.
Run the validation again and try to fix the errors, then, change the status back to needs review, that will save you one not so useful review from another user who would have simply told you about the coding errors mistakes (more back and forth = more time). This is something very common that happens to all of us (and just for one whitespace at the end of the line... the status is changed back to needs work again, which seems to be the case with your code right now).


So far, that's all I could find, but I will try doing a manual review and certainly let you know if I can find anything else.
I hope these comments will help you to improve this nice module.

Cheers!

removed

adding link for review bonus

Hi balintcsaba,

there are a couple more things I found:
1. you should change the 'Setting up this repository locally for the first time' section above to reflect the branch change (from master to 7.x.1.x)
2. Your README.txt contains no useful information about your project, you should add some.

Hi balintcsaba,

while I reviewed the module on a clean new D7 install I found the following issue:
(which is why I',m marking it as needs work)

.info file
since taxonomy_tools_publisher is not a standalone module but part of the taxonomy_tools wrapper module
I think you should add both as the dependencies, otherwise neither Drush nor user will find the dependent projects on d.org

dependencies[] = taxonomy_tools
dependencies[] = taxonomy_tools_publisher

and a couple of personal suggestions:
(for the future - not necessarily for this review process)

you could extend a bit the "How to use" section of the project page
since it could pretty hard to follow those steps for a novice user
and you could also include that information in a hook_help()
implementation and the README.txt for a better UX

you could also add a small configuration UI for this module:
where the user can change currently hard-coded values such as the cache time period

creating a permission for who can configure the above mentioned options
would also solve the 'no permission' behavior when there is no vocabulary enabled to use the taxonomy_tools_publisher module on top of which you are building your permissions dynamically

Don't forget to add the PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you won't show up on my high priority list.

Review Bonus List update

This sounds like a feature that should live in the existing taxonomy_tools project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the taxonomy_tools issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

did not mean to remove the review bonus flag.

balintcsaba is now maintainer of the Taxonomy Tools project, so I think this issue can be closed.

Just post the module as new project application again, mention your other contributions and your review bonuses. Usually we only grant the git vetted user role when a new project actually has to be created.

Edit description