1. This is a blogging theme designed specifically for developers. Because it has a focused purpose, it makes basic assumptions that minimizes setup and unnecessary design clutter. For example, it doesn't use sidebar regions or the site logo setting, but it does come with built-in styling for code snippets, out of the box. The result is a simple theme that is ideal for a developer's personal blog. A thorough search of the themes directory on Drupal.org revealed a couple themes that look similar, like http://drupal.org/project/minimalist and http://drupal.org/project/superclean. However, these themes differ in that their multi-purpose nature prevents the design simplicity and support for code snippets that Writer provides. It also helps that writer is a responsive design that makes it easy to read on mobile devices. For more information about the details influencing the design, see https://www.bryanbraun.com/2013/01/19/writer-a-blogging-theme-for-developers/
  2. Here's a screenshot of the theme:
    Screenshot of the Writer theme.
    You can see more screenshots on my project page (link below)
  3. You can see my project page at http://drupal.org/sandbox/bryanbraun/1833840
  4. Here are the links to my git repository (for both Drupal 6 and Drupal 7 versions of the theme), as given on the "version control" tab of my project page:
    git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/bryanbraun/1833840.git writer
    cd writer
    git clone --recursive --branch 6.x-1.x http://git.drupal.org/sandbox/bryanbraun/1833840.git writer
    cd writer
  5. The code includes a branch for both Drupal 6 and Drupal 7.
  6. See below for reviews of other projects

Other details that support the idea of me being a project maintainer: I have been involved with Drupal for about 16 months. I have attended a Drupalcon and made documentation contributions in the past. I am currently employed as a Drupal Front-end developer at Acquia and I learn more about Drupal best-practices each day. I blog about Drupal and Web Development topics at https://bryanbraun.com. You can see my drupal.org profile at http://drupal.org/user/1410008.

Reviews of Other Projects

CommentFileSizeAuthor
#7 2012-12-25-102630_1024x768_scrot.png90.11 KBrickumali

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxbryanbraun1833840git

bryanbraun’s picture

bryanbraun commented

Thanks for the advice and for pointing me to the pareview review. It looks like I have a lot of work to do. I'll get to it.

bryanbraun’s picture

bryanbraun commented
Status: Needs work » Needs review

I've made changes to both 6.x-1.x and 7.x-1.x, so neither of them return errors on PAReview, Drupal Code Sniffer, or Coder Module (including 'tough love'). If somebody is available, then please review. I'll work toward a review bonus when I get a chance.

cog-axis’s picture

cog-axis commented

Hi Bryan,

I have checked tested your code PAReview and also on coder module. It is passed from them. However when I edit the settings and change "Styles for Code Snippets" I get these warnings. I'm using Drupal 7.16.

Notice: Undefined index: logo_path in system_theme_settings_validate() (line 631 of C:\xampp\htdocs\drupal7\modules\system\system.admin.inc).
    Notice: Undefined index: logo_upload in system_theme_settings_submit() (line 679 of C:\xampp\htdocs\drupal7\modules\system\system.admin.inc).

In style.css at line 415 fro D7 and for D6 line 308, there is comment /* ? */ do we require this.

I have gone through the template files in template.php at line no. 55 for D7 and for D6 line no. 45, please use t() for localization for comment date.

Your theme is good light and have good color scheme good luck :-)

Thanks!

bryanbraun’s picture

bryanbraun commented

Thanks for checking the theme. The errors you found are a known bug in Drupal 7 (see http://drupal.org/node/1149900). They show up if no site logo is set as a default setting in the theme. A solution is being built for Drupal 8 and possibly backported to Drupal 7.

I've removed the /* ? */ comments, which were only in there as a reference while coding.

I've also used t() to for localization on the lines you indicated.

As far as I know, that addresses all the issues raised thus far, and the theme needs review once again.

bryanbraun’s picture

bryanbraun commented
Issue summary: View changes

Changed my git clone command which was partially incorrect.

bryanbraun’s picture

bryanbraun commented
Issue summary: View changes

Added the "Reviews of Other Projects" Section. I am reviewing other themes because that is the area I am most familiar with.

bryanbraun’s picture

bryanbraun commented
Issue summary: View changes

Cleaning up the info in my description field

bryanbraun’s picture

bryanbraun commented
Issue summary: View changes

Added another project review comment.

bryanbraun’s picture

bryanbraun commented
Issue tags: +PAreview: review bonus

I've reviewed three other projects to earn a review bonus. See the bottom of my issue summary for links.

rickumali’s picture

rickumali commented
Title: Writer » Some Issues with Comments
StatusFileSize
new 2012-12-25-102630_1024x768_scrot.png90.11 KB

Bryan,

This is a manual look at your theme on my D7 development environment, which already has bunches of random content (with content type "Article") generated by Devel. It's a gorgeous looking theme!

My issue (comment) is about comments. When I view my content's comments, the tag for the username doesn't get processed. I've attached a screen shot of what I saw.

Please let me know if it's something on my side! Please let me know if I should put something into your issue queue. Good luck with the process!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Some Issues with Comments » Writer
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Looks RTBC to me after a manual review! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

bryanbraun’s picture

bryanbraun commented

@rickumali that issue you described has been corrected.

Thanks everyone for the feedback and for taking time to help review!

rickumali’s picture

rickumali commented

@bryanbraun I did a "git pull" to update the code, and confirm that it's fixed in my testing environment.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, Bryan!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

bryanbraun’s picture

bryanbraun commented

Thank you, and thanks to everybody who helped!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added another project review link.

bryanbraun’s picture

bryanbraun commented
Issue summary: View changes