TagCloud Block

Hi jibla,

Please to fix ventral check errors first:
http://ventral.org/pareview/httpgitdrupalorgsandboxjibla1838174git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

Hi jibla,

Thanks very much for sharing this module.

A few comments on top of the one posted by Jordan_Fei (#1):

Project page looks good, with screenshots and installation instructions

README.TXT
Sorry: README.md is not enough.

Please create a README.txt that follows the guidelines for in-project documentation.

Master branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Similar modules?
In what ways would this module be different from: TagCloud, for example.
Maybe you could add a ticket in TagCloud module's tracker to elaborate in more details.

It seems that TagCloud provides very similar functionality. Could you describe how your module differs?
We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

Inline Comments: [tagcloud.module only contains "Implements hook_xxxx"
Could you please add some inline comments in big functions sections?

Your code does not seem very well commented, please make sure it´s clearly understandable by other developers. Please have a look at the module documentation guidelines and the Doxygen and comment formatting conventions

Manual Review: Watchout for unistall variables
I haven't checked the code that much to be honest, but I saw a few variable_get, variable_set calls around.
Usually that means you've defined variables, for example: tagcloud_block_ids.
So I just wanted to recommend that you should perhaps double check that when the module is uninstalled the variables should be deleted.
For that you could perhaps have a look at other modules, for example: Chosen, chosen.install (I tried to pick a rather simple module as an example).
I haven't taken the time to test that myself yet, but thought it might be useful to point that out.

That's all I could find so far, but I will certainly keep checking and let you know if I am able to find anything else.
I hope these several comments can help improving this great module.

Cheers!

file tagcloud.admin.inc
hook_menu.
Remove the extra space from between the keys, identifier and values of the menu item. It should be enough with one space.

hook_block_configure.
The same goes here, but with the form item.

  /**
   * callback function for mapping tags array
   */
  function _tagcloud_vocabularies_callback($item) {
    return $item->name;
  }

There are extra spaces here. You should remove that.

  <?php foreach ($tags as $key => $tag): ?>
    <span class="tag tag-<?php print $tag['font_size']; ?>" style="font-size: <?php print $tag['font_size']; ?>px;">
      <?php print l($tag['name'], 'taxonomy/term/'.$tag['tid']); ?>
    </span>
  <?php endforeach; ?>

This is open for discussion, but shouldn't you be moving this piece of code in the actual theme function?
I suggest: template_preprocess_tagcloud_block_view()

1. STUPID QN (but needed for me): Am a newbie for drupal. I read on many pages that Tagadelic is not suitable (stable) for D7. Please let me know final answer since the posts I read were of 1 years back. So is there any final module for this which I can use in my Appliacation? If then please provide me link ( and if possible- documentation/steps of using the same).

Hi priti_p,

I strongly advise that you ask these types of questions in IRC#drupal or in the Forum. I don't think it would be suitable to ask this question on this project application.

I personally think it's completely off topic.

Did you take the time to read previous comments, in particular #2?

It seems that TagCloud provides very similar functionality.

How about taking a closer look at the suggested modules? (they are compatible with D7)

If it still doesn't fit your requirements, I would recommend you try asking on IRC or in the Forum.

Getting back to this application, we still haven't received any reply from the author and as the module is right now, I (personally) wouldn't agree on moving this application forward as it seems to duplicate other modules' functionality.

Any more feedback, comments, reviews, questions, recommendations, suggestions or objections would be highly appreciated.
Cheers!

Attempted to get this module to work so I could provide a proper review but I received the following error after enabling the module:

Notice: Undefined variable: form in tagcloud_add_block_form() (line 46 of /var/www/modules/tagcloud_block/tagcloud.admin.inc).
Notice: Undefined variable: block_data in tagcloud_block_configure_block() (line 68 of /var/www/modules/tagcloud_block/tagcloud.admin.inc).

After attempting to edit the configuration file in Drupal:

Notice: Undefined property: stdClass::$title in tagcloud_block_view() (line 91 of /var/www/modules/tagcloud_block/tagcloud.module).

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Added more details in description.