Christmas Lights

welcome Andrew,
please check http://ventral.org/pareview/httpgitdrupalorgsandboxserm1871370git-7x-10

Hello serm,

You should also fix your branches on git.
You must delete your master branch and rename your dev branch appropriately. (see attachments)

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hello,
Please check

http://ventral.org/pareview/httpgitdrupalorgsandboxserm1871370git

I'm a first time reviewer, so I was delighted that this module had a succinct piece of functionality.

First, I was able to get the module running, but I had to read the code. My first piece of feedback: update the documentation to state that the Drupal administrator must visit the module configuration (admin/config/system/christmas_lights).

Second, I enabled it, but the default admin theme hid the lights, so I wasn't sure that it was working or not. Once I logged out, and the admin toolbar disappeared, I saw the lights on the top of my page. I was delighted! Again, though, it would be good to call this out.

That's it! The main point for me is 'documentation'. Some nice things for your next version:

1) Perhaps some configuration for the kinds of lights available (all white, mix, all red, etc.)
2) Perhaps some Drush capabilities (like enabling or disabling)

Good luck!

serm, where are the links to the 3 projects you helped review to get the review bonus?

Hi serm,

This is a nice module but there are some bugs in this module please try to resolve below mentioned bugs.
1) Admin settings for this module is not working properly. When I was trying to change the start date from "Dec 1 2012" to "Dec 15 2012" it is not saving new start date. Same issue with end date.
2) You should use validation handler for start date and end date validations. Suppose user select start date "Jan 15 2013" and end date "Dec 1 2012" in this case start date is greater than end date which will be incorrect and use form_set_error() to display errors.
3) You should use drupal_set_message() in submit handler to display message to a user that your configuration settings has been stored.

Removing bonus tag you can review other project application and again add Review bonus tag.

Hi serm,

Everything is looking good to me. Thanks for your contribution to Drupal Community and for your patience.
This is a small module so we cannot give you GIT vettted role but we can promote this a single project.

Removing bonus tag you can review other project application and again add Review bonus tag.

Your project page is a bit short, see http://drupal.org/node/997024

Thanks for your contribution, serm!

I promoted this to a full project for you: http://drupal.org/project/christmas_lights

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.