Views Slideshow Liquid Slider

Hello,

We found several errors on your module, you may like to look at the following URl for list of errors

http://ventral.org/pareview/httpgitdrupalorgsandboxsteveoriol1885704git

Do take time to rectify the issues.

Hi steveoriol,

Great module, thanks for putting this together. I can see myself using this in the future.

Here's my review:

Automated:
Clean as a whistle!

Manual:
In general your code is clean and easy to follow. Well done!

Install and use:
Worked exactly as expected. Instructions on the views form are clear. Again, well done!

README.txt :
Install instructions are clear, even the tricky jquery copying process. Installed using drush without an issue.

theme/views-slideshow-liquidslider-main-frame.tpl.php :
* line 12: You have some debug code hanging around here. Should be cleaned up.

views_slideshow_liquid_slider.module :
line 105: typo, isntall -> install.

liquidslider.css :
this css file is empty, perhaps remove it?

Overall, really clean and simple module. Nicely done! None of the issues above are RTBC blockers, so I'm going to mark this as RTBC.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

add git command line

Don't forget to add the "PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you won't show up on my high priority list.

You have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

Well, apologies in advance, but I can't promote this module without at least a short discussion on module duplication. Nothing against this module in particular ... but Views slideshow modules have long been the poster child for module duplication in Drupal. As an end user who wants to put a rotating slideshow banner on their Drupal website, how do I decide which of the 174 available options I want to use? Choice is good, but too much choice is overwhelming. http://drupal.org/node/418616 and http://groups.drupal.org/node/20384 help to illustrate the scope of the issue.

Obligatory lecture aside, on to the module. ;)

Thanks for your contribution, steveoriol!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.