Views BeautyTips

Hi Nikro,

Great job done so far! I really like the clean and commented code and the idea.

Some minor things to your attention:

It looks like you still have master branch. It's recommended to work in version branch and even delete master branch to avoid confusion.
There are some thoughts about this described here: http://drupal.org/node/1127732

Also you specified as your module package "User interface". Since your module provides only Views related functionality you may consider changing the package to "Views". Take a look at documentation about package

Otherwise looks pretty cool.

Project page
Looks ok, but it would be more beautiful if the text would float around the image.

As i understand it correctly, by "Replacement Tokens" you dont mean the normal tokens (http://drupal.org/project/token) used everyhwere in drupal, right?
This may be something you could note on the project page as well.

Code
1. Code style looks good according to http://ventral.org/pareview/httpgitdrupalorgsandboxnikro1805510git - most issues are inherited by views. The only outstanding (but not critical) ones are lines that exceed 80 characters.
2. There is a master branch remaining in the repo, please remove it.
3. There is a TODO comment in file views_beautytips.module. If you dont support all (basic?) field types, please note this also on the project page and within the README.

Didnt find any other code issues at the first place, looks very well!

Still missing coding standards. see here:
http://ventral.org/pareview/httpgitdrupalorgsandboxnikro1805510git

Hello Nikro,

very cool module, I use it by now.

Here's my review:

Code:
In general your code is clean and easy to follow. Well done!

Install and use:
Worked exactly as expected.
Instructions on the views form are clear. Again, well done!

README.txt :
Install instructions are clear.
Installed using drush without an issue.

Overall, really clean and simple module. Nicely done!
I do not find issues what are RTBC blockers, so I'm going to mark this as RTBC.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

manual review:

1. "module_invoke_all('views_beautytips_handler_items', $items);": Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php
2. "t('<p><span>For more details read the !documentation</span></p>'": HTML tags should be outside of t() when possible. Also elsewhere.

But that are not application blockers, so ...

Thanks for your contribution, !

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.