Closed (fixed)
Project:
Internationalization
Version:
7.x-1.8
Component:
Menus
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Jan 2013 at 07:24 UTC
Updated:
9 May 2013 at 17:19 UTC
Jump to comment: Most recent file
Comments
Comment #1
berdirI would say a fatal error is not minor :)
Comment #2
jose reyero commentedYeah, upgrading to major and moving to component "Menus"
As @Berdir points out:
- This seems to be caused by this patch #1693074: Change menu translation approach (i18n_menu_translated_menu_link_alter() skips item subtree processing)
- More information here https://drupal.org/node/1693074#comment-6954254
I'd say that there are some tests missing for this 'translate menu item' pages too.
Comment #3
jose reyero commentedI've done some research and this is what's going on:
- Views menu items, as other items defined by modules should have their title translated by t().
- These items only have translatable strings if either the title or the description are customized.
This patch will replace the error with a 'No available strings for translation' message, which I think gives more clues to the user than just not showing the 'Translate' tab for such items (that is the other option).
Downgrading to 'normal' since this is not even a missing feature, just a page that shouldn't do anything. Please review and test.
Comment #4
berdirTypo :)
Comment is specific to menu items, but this is a generic method...
The error message is not *that* helpful but making something better is hard as, as I said, this is a generic method :)
Applied patch and the fatal error is gone, which is not that surprising.
Comment #5
jose reyero commentedThanks for the quick review.
Fixed typos, better comments.. Committed.
Comment #6
rutcreate commentedpatch #3 works perfectly. but menu item still does not translated. I try with:
Menu title: Log out
Path: user/logout
When I visit translation page, message 'This object has no strings available for translation.' is show up. So I go to translate interface (admin/config/regional/translate/translate). Translate 'Log out' to my language but it does not display correctly.
Comment #8
jaypanPatch from #3 works for me.
Comment #9
jose reyero commentedWell, if patch #3, which is committed, works, this is fixed then.
About these menu items, nope, they're not translatable using this module because they are produced by another module, and not (core) custom menu items, which what i18n_strings translates.
So this is to be fixed in views, or maybe i18nviews, not here.