Sandbox: http://drupal.org/sandbox/stevector/1896114

For use with Drupal 7.x

This is a bridge module to ease simultaneous usage of Organic Groups, Fieldable Panel Panels and Panelizer. Panelizer is not a technical dependency for this module though it is involved in the most likely use case.

Use case

  • A University uses Organic Groups to segment content by academic department. So "Chemistry Department" and "English Department" are group nodes.
  • Panelizer is used to custom layouts on a node by node basis.
  • Departments used Fieldable Panel Panes to common sidebar elements like "Chemistry Department's quick links"
  • Because Fieldable Panel Panes are an entity type they can belong to an Organic Group. So the "Chemistry Department's quick links" pane can be designated as belonging to the Chemistry group.
  • Fieldable Pane Panels can be reusable so they show up in the CTools modal that lists available panes when panelizing a node.

This module filters the list of available Fieldable Panel Panes in the CTools modal based on the Organic Group of the node being panelized and the Organic Groups of the individual Fieldable Panel Panes.

This project also includes an example Features module for testing. See the README.txt for additional testing instructions.

Reviews of other projects

Comments

miloyz’s picture

miloyz commented
Status: Needs review » Needs work

Hi stevector,

Thanks very much for submitting this very interesting module.

Please find below an initial automated review mostly from from PAReview and it seems there are quite a few errors for you to fix already:

Master branch
Project is using 7.x-1.x branch, master branch has been removed [OK]

Project page
Your project page already looks good.
Very quick comments if you wanted to quickly improve it, I would recommend adding a small section for Requirements, since it seems this module has dependencies.
Screenshots could also be a good idea to make things easier to understand for some users.

Automated review
PAReview code validation prompted errors:
http://ventral.org/pareview/httpgitdrupalorgsandboxstevector1896114git
Please fix the validation errors as indicated.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxstevector1896114git.

So far, that's all I could find and it seems many other points from the project application checklist are fine (Basic application checks, Basic Repository checks, Licensing checks, etc...).
But I think we should be giving this project more reviews after these issues have been fixed.

Feel free to let me know if you would have questions, comments or concerns on these items, I would surely be glad to provide more information.

Hope that helps getting module's review started.
Cheers!

vineet.osscube’s picture

vineet.osscube commented
Status: Needs work » Needs review

Hi stevector,
Firstly there is lots of issue regarding line spaces, indentation & comments.

Look at this !
http://ventral.org/pareview/httpgitdrupalorgsandboxstevector1896114git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

dydave’s picture

dydave commented
Status: Needs review » Needs work

Following up with previous comments, I quickly allowed myself to change application's status to needs work.

Feel free to change the status back to needs review when these issues have been fixed.

Thanks very much to all for your comments and reviews.
Cheers!

stevector’s picture

stevector
he/him
commented
Status: Needs work » Needs review

Thanks so much for the reviews everyone!

I've added a screenshot and a requirements section to the project page: http://drupal.org/sandbox/stevector/1896114

I have addressed this issues in http://ventral.org/pareview/httpgitdrupalorgsandboxstevector1896114git as best as possible. There are some places where shorter line lengths is not practical. Unfortunately, overriding the verbose function names of Fieldable Panel Panes and CTools means creating even more verbose function names. This error "Arguments with default values must be at the end of the argument list" is also unavoidable because of the method CTools passes in arguments. This is the same argument structure as used by the function that this function is overriding.

The bulk of the notices in http://ventral.org/pareview/httpgitdrupalorgsandboxstevector1896114git are in the example module which is generated by Features. I don't think it should be modified.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

I agree that issues with the generated features module are out of scope, and that function names are exempt from the 80-character rule. This module is also already doing well in production, and the maintainer is already an active and successful contributor to other modules.

I'd say this is ready.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

Don't forget to add the "PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you won't show up on my high priority list.

Git default branch is not set, see the documentation on setting a default branch.

But otherwise looks good, so ...

Thanks for your contribution, stevector!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well

stevector’s picture

stevector
he/him
commented

Default branch set.

Thanks klausi!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Adding list of reviews of other projects.