QuickTabs Field Collection

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

There are a couple small issues you can address here:
http://ventral.org/pareview/httpgitdrupalorgsandboxstevenwichers1901520git

Otherwise I think the module looks great. I've tested it and seems to do what it says.

Minor coding standard issues are not application blockers. Anything else?

quicktabs_field_collection.module
Lines 284, 287 & 288 the variable $settings is never defined. I changed it to $formatter_settings and it fixed it.

I get the following error when using ui_tabs renderer. It still works, but you'll probably want to define history in your options.
Notice: Undefined index: history in QuickUiTabs->add_attached() (line 108 of /home/drupal7/public_html/sites/default/modules/quicktabs/plugins/QuickUiTabs.inc).

I could not get the Accordion render to work. It give these errors. See related issue in QuickTabs issue queue. http://drupal.org/node/1664468

Notice: Undefined index: history in QuickAccordion->add_attached() (line 85 of /home/drupal7/public_html/sites/default/modules/quicktabs/plugins/QuickAccordion.inc).
Notice: Undefined index: jquery_ui in QuickAccordion->add_attached() (line 92 of /home/drupal7/public_html/sites/default/modules/quicktabs/plugins/QuickAccordion.inc).
Notice: Undefined index: history in QuickAccordion->add_attached() (line 92 of /home/drupal7/public_html/sites/default/modules/quicktabs/plugins/QuickAccordion.inc).

Setting the options to to the code below fixes the accordion, however you probably want to set the options dependent on what render is selected.

 'options' => array (
          'history' => 0,
          'jquery_ui' => array(
              'autoHeight' => 0,
              'collapsible' => 0,
          ),
      ),

Also, I don't believe it's required but you do not have a hook_help function. You might consider adding one.

Everything looks good. No more errors. Code looks good as far as I can tell. I'm not sure if a project requires more then one reviewer to be considered reviewed by the community, so I'll leave it as needs review for that reason.

I only have one minor suggestion but it's not that big of a deal.
The style option is irrelevant for ui_tabs and accordion renderers. You might consider hiding it when those are selected.

Works as advertised. I opened a feature request for supporting view modes in the body of the tabs: #1907718: Add support for using View Modes as the body instead of a single field I also think the code could use more inline comments.

Neither of those should hold up full project promotion.

Thanks for your contribution, steven.wichers!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks to the dedicated reviewers as well.