Commerce TNT

Hi jbloomfield,

Few points after a quick review:

1. $form['#validate'][] is not required at line. 61(commerce_tnt.admin.inc) as after submitting it automatically goes to validate hook.
2. Formatting issue please check at http://ventral.org/pareview/httpgitdrupalorgsandboxjbloomfield1893182git.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. project page is too short, see http://drupal.org/node/997024
2. "require 'commerce_tnt.xml.inc';": why do you globally require that file? If you do that in the module file scope it will be loaded on every single page request. You should only require it if you actually need it in a function body.
3. commerce_tnt_commerce_shipping_service_info(): the t() calls are useless here because you already call t() on the service title elsewhere? Double translation?
4. "'@code' => check_plain($response->ratedTransitTimeResponse->brokenRules->brokenRule->code),": double escaping - the "@" placeholder with t() will already run check_plain() for you, and double escaping is bad. Please read http://drupal.org/node/28984 again.
5. commerce_tnt_entity_presave(): shouldn't you implement the entity type level hook_commerce_product_presave() if you are only interested in one entity type?
6. commerce_tnt_build_rate_request(): why do you iterate over the DB $result? Just use ->fetchAll() and you don't need the loop?
7. commerce_tnt_api_request(): why can't you use drupal_http_request() instead of cURL? Please add a comment. And if you keep cURL please add hook_requirements() like simpletest does: http://api.drupal.org/api/drupal/modules!simpletest!simpletest.install/f...

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Great, looks RTBC to me now. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to MiSc as he might have time to finally approve this.

Thanks for your contribution, jbloomfield!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.