This module allows commenting on fields for any field display.

Comments on particular field can be enabled at the Manage display settings for content types.

A checkbox is available for each field, revealed by using the formatter settings edit button (Gear wheel icon) for that field.

https://drupal.org/sandbox/Lamp-Development/1908332

The repository can be found here: git clone http://git.drupal.org/sandbox/Lamp-Development/1908332.git field_comments

My reviews:
http://drupal.org/node/1915476#comment-7061342
http://drupal.org/node/1914740#comment-7061444
http://drupal.org/node/1913566#comment-7061616

http://drupal.org/node/1919516#comment-7076152
http://drupal.org/node/1917832#comment-7076190
http://drupal.org/node/1917730#comment-7076224

CommentFileSizeAuthor
#7 various.patch3.43 KBnoels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vladimir-m’s picture

Status: Needs review » Needs work

Hello PawelR,

Thank you for great module.

Manual review:
1. Please add git link corresponding to non-maintainer, for example: "The repository can be found here: git clone http://git.drupal.org/sandbox/Lamp-Development/1908332.git field_comments" instead "git clone --recursive --branch 7.x-1.x-dev Lamp-Development@git.drupal.org:sandbox/Lamp-Development/1908332.git field_comments". Take a look to http://drupal.org/node/1011698
2. Take a look to this http://ventral.org/pareview/httpgitdrupalorgsandboxlamp-development1908332git automatic review.
3. I think you module need feeld_ui dependencies. Try to add to info file: dependencies[] = field_ui

PawelR’s picture

Hi Vladimir,

I've just sorted these issues.

Thank you

PawelR’s picture

Status: Needs work » Needs review

status change

vladimir-m’s picture

why you are use 7.x-1.x-dev instead 7.x-1.x branch? take a look to http://drupal.org/node/1127732

monymirza’s picture

Status: Needs review » Needs work
PawelR’s picture

Status: Needs work » Needs review

Thanks Vladimir, this is now fixed.

noels’s picture

Status: Needs review » Needs work
FileSize
3.43 KB

Tidy up a couple of things.

PawelR’s picture

Committed, thanks.

PawelR’s picture

Status: Needs work » Needs review
noels’s picture

Status: Needs review » Reviewed & tested by the community

Works for me. Thanks for the module.

noels’s picture

Issue summary: View changes

proper repository URL

PawelR’s picture

Issue summary: View changes

typo

PawelR’s picture

Issue tags: +PAreview: review bonus

added review bonus tag

klausi’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -PAreview: review bonus

manual review:

  1. project page is a bit short, does this module depend on core's comment module? See also http://drupal.org/node/997024
  2. field_comments_schema(): node id is mentioned here, so does this module only work for nodes?
  3. "'access arguments' => array('access administration pages'),": The administration menu callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.
  4. field_comments_menu(): again nodes here, could this be changed to work with any entity type?
  5. Notice: Undefined property: stdClass::$nid in field_comments_submit_node() (line 281 of field_comments.module). Please enable PHP notices in your development environment.
  6. field_comments_form_comment_form_alter(): why do you need $_POST here? Please add a comment.

The permission is an application blocker, otherwise looks pretty ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

Issue summary: View changes

added review links

PawelR’s picture

Issue summary: View changes

another one review link

PawelR’s picture

Issue summary: View changes

another one review link

PawelR’s picture

Issue tags: +PAreview: review bonus

Hi Klausi,

Thanks for pointing these issues, I've just sorted them:

1. Added screen shots and better description.
2. It depends on core's Comment module so it inherits Comment module limitation and works only with node entity type.
3. Fixed.
4. Explained in point 2.
5. Fixed.
6. Comment added.

I've reviewed another 3 projects and added back review bonus tag.

PawelR’s picture

Status: Needs work » Reviewed & tested by the community

status change

klausi’s picture

Assigned: Unassigned » ELC
Issue tags: -PAreview: review bonus

Don't RTBC your own issues, see http://drupal.org/node/532400

Looks RTBC to me now! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to ELC as he might have time to finally approve this.

jthorson’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, PawelR!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

another one review