This module allows commenting on fields for any field display.
Comments on particular field can be enabled at the Manage display settings for content types.
A checkbox is available for each field, revealed by using the formatter settings edit button (Gear wheel icon) for that field.
https://drupal.org/sandbox/Lamp-Development/1908332
The repository can be found here: git clone http://git.drupal.org/sandbox/Lamp-Development/1908332.git field_comments
My reviews:
http://drupal.org/node/1915476#comment-7061342
http://drupal.org/node/1914740#comment-7061444
http://drupal.org/node/1913566#comment-7061616
http://drupal.org/node/1919516#comment-7076152
http://drupal.org/node/1917832#comment-7076190
http://drupal.org/node/1917730#comment-7076224
Comment | File | Size | Author |
---|---|---|---|
#7 | various.patch | 3.43 KB | noels |
Comments
Comment #1
vladimir-m CreditAttribution: vladimir-m commentedHello PawelR,
Thank you for great module.
Manual review:
1. Please add git link corresponding to non-maintainer, for example: "The repository can be found here: git clone http://git.drupal.org/sandbox/Lamp-Development/1908332.git field_comments" instead "git clone --recursive --branch 7.x-1.x-dev Lamp-Development@git.drupal.org:sandbox/Lamp-Development/1908332.git field_comments". Take a look to http://drupal.org/node/1011698
2. Take a look to this http://ventral.org/pareview/httpgitdrupalorgsandboxlamp-development1908332git automatic review.
3. I think you module need feeld_ui dependencies. Try to add to info file:
dependencies[] = field_ui
Comment #2
PawelR CreditAttribution: PawelR commentedHi Vladimir,
I've just sorted these issues.
Thank you
Comment #3
PawelR CreditAttribution: PawelR commentedstatus change
Comment #4
vladimir-m CreditAttribution: vladimir-m commentedwhy you are use 7.x-1.x-dev instead 7.x-1.x branch? take a look to http://drupal.org/node/1127732
Comment #5
monymirzaComment #6
PawelR CreditAttribution: PawelR commentedThanks Vladimir, this is now fixed.
Comment #7
noels CreditAttribution: noels commentedTidy up a couple of things.
Comment #8
PawelR CreditAttribution: PawelR commentedCommitted, thanks.
Comment #9
PawelR CreditAttribution: PawelR commentedComment #10
noels CreditAttribution: noels commentedWorks for me. Thanks for the module.
Comment #10.0
noels CreditAttribution: noels commentedproper repository URL
Comment #10.1
PawelR CreditAttribution: PawelR commentedtypo
Comment #11
PawelR CreditAttribution: PawelR commentedadded review bonus tag
Comment #12
klausimanual review:
The permission is an application blocker, otherwise looks pretty ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #12.0
klausiadded review links
Comment #12.1
PawelR CreditAttribution: PawelR commentedanother one review link
Comment #12.2
PawelR CreditAttribution: PawelR commentedanother one review link
Comment #13
PawelR CreditAttribution: PawelR commentedHi Klausi,
Thanks for pointing these issues, I've just sorted them:
1. Added screen shots and better description.
2. It depends on core's Comment module so it inherits Comment module limitation and works only with node entity type.
3. Fixed.
4. Explained in point 2.
5. Fixed.
6. Comment added.
I've reviewed another 3 projects and added back review bonus tag.
Comment #14
PawelR CreditAttribution: PawelR commentedstatus change
Comment #15
klausiDon't RTBC your own issues, see http://drupal.org/node/532400
Looks RTBC to me now! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Assigning to ELC as he might have time to finally approve this.
Comment #16
jthorson CreditAttribution: jthorson commentedThanks for your contribution, PawelR!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #17.0
(not verified) CreditAttribution: commentedanother one review