Relative timestamps

Hi,

first of all there are quite a few issues to sort out such as indentation, whitespace.

You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandboxpropaganistas1920568git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

# Your first branch name can be 7.x-1.0, version comes after module released.
# Move your code repository to custom branch like 7.x-1.x, then delete master branch.

No errors through PARreview.

Nicely written module. I didn't find any major issues. It does what it says on the tin ;)

+ review bonus program

I hate, hate, HATE coding this manually all the time, so thank you for a cool module. I've got a couple notes for you. Nothing too bad, but some things to think about:

Not sure if you should refer to this style of date as "Facebook style" in the .info file. Not everyone uses Facebook, and Facebook is going to fall out of style at some point and then that association does nothing for you. The rest of your description is fine without it.

In relative_timestamps_format(), you're define()-ing some values with pretty generic names (SECOND, MINUTE), and there's a chance those constants could collide with some other module or theme's definitions. Worse, someone else's code might be using those constants to hold strings instead of numbers, which would break your calculations. Instead of using define() there, how about switching to static variables? That way, your definitions still aren't going to get re-defined every time the function is called, but they're limited to the function's scope. For example:

if (!defined("MONTH")) {
    define("MONTH", 30 * DAY);
  }

should become

static $MONTH;
if(!isset($MONTH)) {
  $MONTH = 30 * $DAY;
}

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

1. relative_timestamps.info: why is there no dependency to the date module?
2. relative_timestamps_field_formatter_view(): the switch() is not necessary since you provide only one case with that callback anyway?
3. "return $delta >= 0 ? $timestr . ' ' . t('ago') : t('in') . ' ' . $timestr;": do not concatenate variables to t() calls, use placeholders with t() instead. Same elsewhere.
4. I thought that you maybe could use hook_date_format_types() and friends to make this available to any date displayed in Drupal, but format_date() only works with PHP date patterns and does not support callbacks. Sad story.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

I'm a fan of nicely structured project pages with usage examples and screenshots!
But I'm not a fan of yours, yet ;-)

"relative_timestamps_worker" is an odd function name for what it does.. maybe "relative_timestamps_generate"?

/**
  * @file
  * The basic .module file <--------- This comment is not helpful!
  */

but that's just nitpick..

I also quickly tested it on simplytest.me and everything seemed to work fine.

A small, solid module, ready to go..

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.