Grid Field Formatter

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Updated issue summary.

Hi,

I have reviewed your module. It looks good.

Only some of minor issues mentioned by ventral about coding standards.

And File : grid_field_formatter.module
Line 78 : Move down elseif to one line and If you can add else condition, that will be good.

Thanks and Regards,
D. Veera Prasad.
www.drup-all.com

Hi veeraprasadd,

Thanks very much for your comment and interest for this project application.

Only some of minor issues mentioned by ventral about coding standards.

I'm very sorry, but I have tried looking at the Automated Review on Ventral/PAReview, I also repeated the review, several times, but couldn't find any issue indicated there.

Could you please paste a valid link in a comment to indicate the errors you encountered prompted by an automated review of the code? Otherwise, could you please copy/paste the report from PAReview/Ventral in another comment?

As for the elseseif, to be broken into a new line, it sounds like a valid comment, but since it doesn't seem to be specifically specified in coding standards or prompted as an error by any automated reviewing tool, I would assume it would be a pretty minor change that shouldn't prevent this module from being further reviewed.

Therefore, I'm allowed myself to change the status back to needs review and we'll surely take your comment into consideration a little later.

Feel free to change the status back to needs work if you encounter any other issues while reviewing module's code.

Any of your comments, feedback, testing, reporting or questions would be highly appreciated.
Thanks again very much for your review.
Cheers!

Hi DYdave,

Here is the link I have got once I run automated project review in ventral.org

And please find attached image which has listed errors.

Regards,
D. Veera Prasad.
www.drup-all.com

Hi veeraprasadd,

Thanks very much for your time and pasting again the link to the review page.

I'm still not clear why/how I could have missed that....
Anyway, these were only really minor issues, wrong white spaces, missing spaces or empty lines at end of doc.
It seems that all the issues have been fixed now and I invite you to take another look (at 3115d76).

Thanks again, very much for your feedback, review, testing and reporting.
Cheers!

✓ Automated review

http://ventral.org/pareview/httpgitdrupalorgsandboxalfababy1852610git
Looks good!

✗ Manual review

• ✓ Project page is great.
• ✗ Going to the "Manage Display" page for the first time, I got the following:
  Notice: Trying to get property of non-object in grid_field_formatter_get_enabled_field_formmater() (line 227 of /Users/aendrew/Sites/drupal-7.x-dev/sites/all/modules/grid_field_formatter/grid_field_formatter.module).
  I then realized I hadn't configured it at the page mentioned in the README. Really, you should have a check for that -- code shouldn't throw notices at any stage of configuration.
• ✗ grid_field_formatter.module -- ln. 55: minor, but you spell "formatter" wrong in $enabled_field_formmater and then again in other variables. For the sake of your sanity in six month's time, please fix those!
• ✓ grid_field_formatter.install -- Good! Cleans up variables.
• ✓ grid_field_formatter.admin.inc -- Good!
• ✓ grid_field_formatter.info -- Good!
• ✓ grid_field_formatter.admin.inc -- Good!
• ✓ grid-field-formatter.tpl.php -- Good!
• ✓ README.txt -- Good!

You're pretty much there! Fix the two small things I flagged up and I'll RTBC it.

Hi aendrew,

Thanks a lot!
This clearly needs some work and I've posted an issue for that at #1929256: Notice after going to the "Manage Display" page for the first time [nothing configured].

I'll leave the status in needs review for now to see if this project application could get any more reviews in the meantime.
Hopefully ticket #1929256: Notice after going to the "Manage Display" page for the first time [nothing configured] should get resolved very shortly.

Thanks in advance for any further comments, feedback, or reviews.
Cheers!

Hi! I've added to the above. At this point, just fix that misspelled variable and I'll RTBC it.

manual review:

1. "t('Number of columns: @columns', array('@columns' => filter_xss_admin($columns)));": the "@" placeholder will already run check_plain() for you, so no need for filter_xss_admin().

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to zzolo as he might have time to take a final look at this.

Add review bonus

Hi DYdave,

No issues found in ventral.org
Looks good.

Thanks and Regards,
D. Veera Prasad.
www.drup-all.com

Thanks for your contribution, alfababy!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.