carouFredSel slider

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

I think you should add dependencies on Field and Field UI

It's not clear to me how to use the module. I think the README needs some more work. I was able to install the module and related library but am not sure where to go from there. At what path in the UI can I see the interface/functionality this module adds? I had a look in the settings for one of my image fields, but the settings form appears to be unaffected by this module. Please add some more instructions/examples for usage in the README, so people know how to get started.

At first glance the PHP seems pretty clean, although there are four problems the coder module catches. I recommend installing the coder module and using it to inspect the code, and you'll quickly fix those little problems. http://drupal.org/project/coder -- Of course, you may already have done this and I may be seeing some minor problems that have crept in more recently.

"You get an additional formatter for image fields in the manage display section of every content type."

Thanks. That's what I needed. I will have another look!

@bkonetzny -- I found the UI for this module in the Manage Display tab. It looks nice. However, I am not able to get the module to do anything on the front end. I tried in the Garland and Bartik themes. I see that your javascript is included in the head of the document, but all I have in the output is a list of images and no carousel functionality. In firebug I am seeing this error:

TypeError: $(...).carouFredSel is not a function
[Break On This Error] 	

$('#' + selector, context).carouFredSel(config);

I have your library installed inside of /sites/all/libraries/caroufredsel/
So I have a file at this path: /sites/all/libraries/caroufredsel/jquery.carouFredSel-6.2.0.js

@bkonetzny: I fetched your latest code and the slider is now working.

Is there another module that provides a carousel formatter like this? It looks like there are some other carousel modules but I'm not sure if there are any that handle turning multiple image uploads in the same field instance into a carousel. It seems like a good approach. Can you comment on whether there are other similar modules available?

I did some testing of the settings and nothing is broken in any way that I can see. I still think you need a little more explanation of how to get started with the module, in your README and project page. You could add steps 4 and 5 to your project page. Something like...

4. Add an image field to any fieldable entity. Be sure to configure the image field to allow more than 1 image.
5. Visit the display settings for the entity. For nodes, this is the Manage Display tab for the content type. Configure the format of your image field to use the carouFredSel formatter, then configure the formatter. When you are done, click Update below the formatter configuration, then click Save.

Or you could make this a separate "Getting Started" section.

I see no reason why two different modules shouldn't use the same library. That's what libraries are for. The more important question is whether there are other modules that provide a carousel formatters for image fields. Even if there are, it seems to me the config needs for one particular slider (e.g. carouFredSel) are going to be different enough from another slider that an additional module is justified. So to me this doesn't seem like a duplicate module. I will mark as reviewed & tested.

Added review link

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. caroufredsel_slider_field_formatter_view(): instead drupal_add_js() you could also add the setting with #attached?
2. caroufredsel_slider_theme(): doc block is wrong.

But that are not blockers, so ...

Thanks for your contribution, bkonetzny!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.