[D7] Taxonomy to Apachesolr Link

Automated review

The automated review indicates serveral problems, these problems should be fixed.

Manual review

The code looks very good, however I do have a few remarks.

1) For comments, like the one below, you should follow the documentation and comment guidelines.

/**
 * Alter an apache taxonomy link to your liking.
 * $link - The link to display
 * $term - The term taxonomy object
 * $field_name - The current field
 * $search_path - The search path
 * @example 
 * 
 * $link = urldecode($base_url . '/' . $search_path . '/' . $term->name . '?f[0]=im_' . $field_name . ':' . $term->tid);
 */

2) Custom hooks should start with your module name. hook_apachesolr_taxonomy_link_alter should be e.g. hook_taxonomy_to_apachesolr_link_link_alter.

Further you should add a link to your sandbox page to the issue above.

Good job so far, keep it up! ;)

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

I'm a robot and this is an automated message from Project Applications Scraper.

Hi there,

Good job so far. A couple more things to look at:

• Your README.txt should contain more detailed information as per the in-project documentation guidelines.
• You don't really need double quotes in the module's .info file. This is really minor, though.
• Your @file documentation for your .module file should be more detailed. What kind of module is this (block, theme, media, etc...)?

Other than these minor issues, everything looks good to me. Good luck!

Forgot to change the application status to "needs work."

Why do the README instructions start with 2? The search path should probably be a site-wide setting instead of a per-field setting, since it would always remain the same. Or even better just grab the value from the solr module directly. I don't see where you're using $settings['target'], taxonomy_to_apachesolr_link_field_formatter_view() doesn't seem to make use of it? Are taxonomy fields guaranteed to be im_* in solr?

No major issues though, this looks like a handy module.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Thanks for making those fixes, +1 from me.

manual review:

1. taxonomy_to_apachesolr_link.info: dependency to some solr module missing?
2. taxonomy_to_apachesolr_link.info: "configure" property to the settings page is missing
3. Not sure this module uses the right approach - I would just build a solr view to replace the taxonomy term pages.
4. "drupal_alter('apachesolr_taxonomy_link', $link, $term, $field_name, $search_path);": drupal_alter() should only have 4 arguments, see https://api.drupal.org/api/drupal/includes!module.inc/function/drupal_al... (if you need more you need to wrap them in a context array).

But that are not blockers, so ...

Thanks for your contribution, Cristobal Wetzig!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.