Textmarketer SMS Integration

You got a clean review from the code sniffer here:
http://ventral.org/pareview/httpgitdrupalorgsandboxflakmonkey461943208git

The configure path you define in the info file isn't set up anywhere: admin/config/services/sms_textmarketer

I can't find any documentation on this, but I believe the permission key uses spaces rather than underscores as standard.
Not that this will affect anything, just a code styling issue.
see the api example at http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

I'm a robot and this is an automated message from Project Applications Scraper.

1) I've installed:
- http://drupal.org/project/libraries
- http://drupal.org/project/smsframework (7.x-1.x-dev)

and gettings the following notices on /admin/modules page:

Notice: Use of undefined constant SMS_TEXTMARKETER_LIBRARY - assumed 'SMS_TEXTMARKETER_LIBRARY' in sms_textmarketer_requirements() (line 24 of /sites/all/modules/textmarketer_sms_integration/sms_textmarketer.install).
    Notice: Use of undefined constant SMS_TEXTMARKETER_LIBRARY - assumed 'SMS_TEXTMARKETER_LIBRARY' in sms_textmarketer_requirements() (line 54 of /sites/all/modules/textmarketer_sms_integration/sms_textmarketer.install).
    Notice: Use of undefined constant SMS_TEXTMARKETER_LIBRARY - assumed 'SMS_TEXTMARKETER_LIBRARY' in sms_textmarketer_requirements() (line 55 of /sites/all/modules/textmarketer_sms_integration/sms_textmarketer.install).

2) Module sets variables in sms_textmarketer_admin_form(). You must manually delete the variables when the module is uninstalled in the sms_textmarketer.install:

/**
 * Implements hook_uninstall().
 */
function sms_textmarketer_uninstall() {
    variable_del('sms_textmarketer_user');
    variable_del('sms_textmarketer_pass');
    variable_del('sms_textmarketer_sender');
    variable_del('sms_textmarketer_state');
    variable_del('sms_textmarketer_validity');
    variable_del('sms_textmarketer_email');
    variable_del('sms_textmarketer_custom');
}

I did a manual review of the code, and ran it through codesniffer. I only had one suggestion.

sms_textmarketer.module line 148

The field is called API password but is a textfield. Should this be a password field?
'#type' => 'password',

Looks RTBC to me after a manual review. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to zzolo as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, FlakMonkey46!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.