Youschmooz

Create link on your sandbox project and Git.

I found your project in the Git - file ... looks like Joomla component. Could you please redo this as Drupal component so I can take closer look at the code?

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  

  ./uninstall.jw_schmooz.php
  ./install.jw_schmooz.php
  ./plugins/system/jw_schmooz/tmpl/article.php
  ./plugins/system/jw_schmooz/tmpl/listing.php
  ./plugins/content/jw_schmooz/tmpl/article.php
  ./plugins/content/jw_schmooz/tmpl/listing.php
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /var/www/drupal-7-pareview/pareview_temp/install.jw_schmooz.php
--------------------------------------------------------------------------------
FOUND 287 ERROR(S) AFFECTING 91 LINE(S)
--------------------------------------------------------------------------------
   3 | ERROR | The second line in the file doc comment must be " * @file"
   9 | ERROR | Inline comments must start with a capital letter
   9 | ERROR | Inline comments must end in full-stops, exclamation marks, or
     |       | question marks
  16 | ERROR | Inline comments must end in full-stops, exclamation marks, or
     |       | question marks
  20 | ERROR | Inline comments must end in full-stops, exclamation marks, or
     |       | question marks
  25 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
  25 | ERROR | There should be no white space after an opening "("
  25 | ERROR | There should be no white space before a closing ")"
  26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  26 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
...

Source: http://ventral.org/pareview - PAReview.sh online service

Remove LICENSE.txt, it will be added by drupal.org packaging automatically.

Hi,

In your git branch files are not represent a drupal module.

A drupal module must need:

1) modulename.info
2) modulename.module

files.

Refer this : http://drupal.org/node/416986

Link to the project page and git clone command are missing in the issue summary, please add them.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Youschmooz,

Is funny how you talk to a robot :)
That was an automatic message by the drupal.org system, you forgot to add to your application issue description the link to your project page and the git access.
You will find the example on of my previous projects description at Taxonomy Publisher Filter and Cache Flush.
Also please read the Apply for full projects to avoid such kind of mistake in the future what will slow down your application process.

The correct link is https://drupal.org/sandbox/Youschmooz/1989684 and http://drupalcode.org/sandbox/Youschmooz/1989684.git.

The project page describes the Schmooz service, instead it should describe what the module does (integrate with your service).

You need a branch that contains your code, either 7.x-1.x or 6.x-1.x. delete the master and youschmooz branches.

Remove LICENSE.txt, ",,.php", and cvsignore, and youschmooz.info. Drupal's packaging script will include a license file for you.

Is the name of your module youschmooz or schmooz? Pick one and all filenames/functions should use it.

Delete schmooz_update_7000() and schmooz_update_7001(). The former is empty, and the latter doesn't work. If you want something to happen when the module is installed use hook_install(). That is also the correct place to install your schema, not in an update hook. If you do decide to delete "post comments" permission from 2 roles, be aware that other roles may still have that permission, and you should let the administrator know what you're doing with a drupal_set_message().

In schmooz_element_post_render() it looks like you're trying to implement a SSO, consider using another module for this or make it configurable for the admin. I'm concerned that you're exposing user data.

Make sure curl is present before using it. Or use a hook_requirements() to let the admin know there is a problem.

Last but not least, please follow Drupal coding standards, https://drupal.org/coding-standards. Please fix problems found by automated review at http://ventral.org/pareview/httpgitdrupalorgsandboxyouschmooz1989684git.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Added project link and Git access