Drupal 7 - Project Page

See Automated Review

Git Clone

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/brycefisherfleig/1946490.git clickbank_download
cd clickbank_download

Description

ClickBank Download integrates with the ClickBank.com payment processor to validate purchase data looks legitimate as a form of access control for digital goods. The module creates a custom content type and two taxonomies to make uploading/managing one's ClickBank products fast.

The intended use case is digital content creators who are already selling their content through ClickBank, but are looking for a more secure way to store their files.

Uniqueness

E-Commerce Uniqueness Unlike UberCart, Drupal Commerce, and others, this module does not create a shopping catalog. It focuses exclusively on the delivery of digital goods. No other module integrates with ClickBank.

Access Control Uniqueness Most access control modules validate access via roles. This module does not login in a user or create an account, but merely provides limited time download access to specific file ids via cookies.

Testing Purchases

If you don't have access to ClickBank account, you can do most of the testing by using the "Debug Mode" on the module config page (see README.txt for mor info). Contact me to test a dummy product with a real ClickBank account.

Reviews of other projects

Comments

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

brycefisherfleig’s picture

brycefisherfleig commented
Issue summary: View changes

Reorganized project description and added links to two recent reviews of other projects

brycefisherfleig’s picture

brycefisherfleig commented
Issue summary: View changes

Fixed HTML typo

brycefisherfleig’s picture

brycefisherfleig commented
Issue summary: View changes

Added new review

brycefisherfleig’s picture

brycefisherfleig commented
Issue tags: +PAreview: review bonus
vlad.pavlovic’s picture

vlad.pavlovic commented

Hey bryce,

This is my first kick at the can reviewing, so bear with me, please.

Coding style: On Line 527, the request_params array is missing spaces between the commas in the definition.

When viewing by taxonomy term, I am getting notices about tid being undefined on lines 386, 387, 400, 405. This in turn is causing a warning on array_flip in /includes/entity.inc. tid is in $entities object array, not in $items.

The module code is very well documented.

Problem with going debug is that the Secret key is still required.

Can you please send me the test ClickBank account number?

brycefisherfleig’s picture

brycefisherfleig commented

Thanks so much vlad! I really appreciate the compliments and the feedback.

Did you get a notice from Drupal that the Secret Key was required? It shouldn't be checking that in Debug Mode. I might need to update the documentation to better explain that :-)

I'm changing status to needs work so I can fix the problems you pointed out.

Can you email me the url to the page where you plan to offer the downloads? I need to configure ClickBank to redirect successful purchases to that URL. I'll email you the test credit card, purchase URL, and secret key. I'm sending a private email with my email address.

vlad.pavlovic’s picture

vlad.pavlovic commented
Title: ClickBank Download » [D7] ClickBank Download
Status: Needs review » Needs work

Yeah I got an error message when saving the configuration form because the Secret Key field is required. So in order for it to let me save it (with debug mode turned on), I had to type in a fake Secret Key. Not a huge deal since it doesn't check it, but maybe augment that in a validation function.

brycefisherfleig’s picture

brycefisherfleig commented

Thanks for the feedback! Adding that to my todo list. I don't want to confuse site builders :-)

brycefisherfleig’s picture

brycefisherfleig commented

Okay, I've fixed the taxonomy errors and coding style problems. If you'll need to disable, uninstall, and reinstall the module to get it working.

brycefisherfleig’s picture

brycefisherfleig commented
Issue summary: View changes

Adding review bonus tag and link to my other comments.

brycefisherfleig’s picture

brycefisherfleig commented
Status: Needs work » Needs review

The "Secret Key" is only required when not in Debug Mode. Debug Mode is the default when the module installs now. I believe I've fixed the outstanding issues...

brycefisherfleig’s picture

brycefisherfleig commented
Issue summary: View changes

Removed qualification about PAReview script and fixed formatting of module uniqueness section.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » dave reid
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Review of the 7.x-1.x branch:

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    FILE: /home/klausi/pareview_temp/clickbank_download.module
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 51 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

But otherwise looks RTBC to me after a manual code review. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Dave Reid as he might have time to take a final look at this.

brycefisherfleig’s picture

brycefisherfleig commented

Thank you so much, klausi! You rock my socks.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, brycefisherfleig!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

brycefisherfleig’s picture

brycefisherfleig commented

Thank you so much, klausi!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixed grammatical errors, shortened project description.