[D7] AUL (Access User Lists)

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxmilkovsky1958676git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

It seems you are still working in the master branch. For information on how to change that click here.

Hi a.milkovsky,

You deleted the master branch but you forgot to update the description of your issue.

fix "we won't have long queries with access conditions because we don't have many access "keys"."

Just reviewed the module. It does exactly what is the project description. we are already using it in production in an ERPAL system

URL to git repository

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I also removed the automated review comments from the issue summary.

removed automated reviews.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1985798

Project 2: http://drupal.org/node/1961032

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

manual review:

1. aul_create_new_aul() is just a duplicate of aul_create_aul() and could be removed?
2. aul_add_node(): you could use db_merge() then you don't have to run the select query beforehand.
3. aul_node_access_records(): you are invoking hook_enabled() here, what is that? Do you mean hook_enable()? Is that a hook that your module provides? Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php . And all your hooks should be prefixed with your module's name.
4. Documentation is missing - how is a module supposed to use your API? What does it have to implement? Please provide an example.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

review 3

You need to set the status to "needs review" if you want to get a review, see https://drupal.org/node/532400

You have a typos on your project page and README, "grand per node" should be "grants per node", "usefull" should be "useful", "wery" should be "very". You should always include a space before an opening parenthesis (it's a lot clearer this way). This is(hard to read).

There's no user interface and the module doesn't do anything by itself, you should make a note of that on the project page.

You have a few formatting issues listed here: http://ventral.org/pareview/httpgitdrupalorgsandboxmilkovsky1958676git.

Since your module is providing an API for others to use, your documentation should address that. See Module documentation guidelines.

No other issues found, and those seem minor.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Well, all of the above still applies. Also, don't trust drupal_write_record() so much - it can fail silently in many cases. Since we're in D7 now you may want to support entities instead of nodes.

Thanks for your contribution, a.milkovsky!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.