[D7] Welcome Username

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1965468

Project 2: http://drupal.org/node/1710222

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxnielsdefeyter1965436git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi nielsdefeyter,
it seems almost everyone starting has the same error of having a master branch :-) I had it as well...
Please remove it and set 7.x-1.x as default branch.

Although master branches are commonly used in the Git world, the Drupal community uses major version branches (e.g., 7.x-1.x, 6.x-1.x) instead, since master does not indicate what Drupal version the project is compatible to. Moving from a master branch to a version branch.

To be able to jugde your coding skills and understanding of Drupal, your coding style and security 120 lines of code is the minimum of code needed at the moment.
Your module has 17 lines of actual code and only one function/hook, how are we supposed to say anything about your coding style?

In your .info and readme.txt you are not sticking to the 80 characters rule.

I guess your module doesn't do much, that's why your module page and readme are so short...

Other than that I think it truly is a nice snippet, but not more.
I would copy that into a helper module or the theme, since enabling a lot of modules is slowing Drupal down.
In my opinion this module is too small to be a full grown Module.

If you added more functionality like an admin form to set up what the link is going to be, it would be better.
Maybe go even more abstract and also give an option on the selection rules.
E.g. change other links.

Cheers
bechtold

Drupal Coder said me that you have a problem with yours files.

welcome_username.module

FOUND 8 ERROR(S) AND 1 WARNING(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
  4 | ERROR   | The second line in the file doc comment must be " * @file"
  9 | WARNING | Format should be "* Implements hook_foo().", "* Implements
    |         | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements
    |         | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.".
  9 | ERROR   | Function comment short description must end with a full stop
 13 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
    |         | question marks
 15 | ERROR   | There should be no white space after an opening "("
 15 | ERROR   | There should be no white space before a closing ")"
 16 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
    |         | question marks
 20 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
    |         | question marks
 23 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
    |         | question marks
--------------------------------------------------------------------------------

welcome_username.info

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

README.txt

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 10 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

You can also watch review your module on http://ventral.org/pareview/httpgitdrupalorgsandboxnielsdefeyter1965436g...
Please repair your code according to Drupal coding standards.