[D7] Terms TagIt

Issues:

• I found nothing (yet) that would render the module unusable but code sniffer found some errors which you can see here.

Suggested Future Improvements:

• When the tag attempts to autocomplete it doesn't really filter the drop down menu, typing one character gets me a list of every tag I've ever used(however the character in question is bold everywhere). If I type in the letter y I should be presented with a drop down list of tags that start with y and/or contain y in the name.
• Consider giving the user the ability to go back and edit tags instead of making them delete the tag and rewrite it. Additionally the onblur was more trouble then it was worth, accidentally clicking off the field before finishing a tag occurs more often than you think.

Side Notes:

I really like the module itself, tags by default are a pain to put in and more so if you have a lot of them. The module made typing out tags and removing them a breeze although I have to admit it was exasperating having to delete misspelt tags in order to rewrite them. Over I look forward to the full release of this module.

Hi,
first of all there are a few issues - such as identation, whitespace and please remove all old CVS $Id tags, they are not needed anymore.

You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandboxjerrylow1966786git

There is great tool to check your source code. All issues find there. Please check the issues on the link above

Review :
1) you have all at master branch - create new custom branch eg: 6.x-1.x, move your code to it, and then delete the master branch.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, you wrote nice module. And I have not found any remark.

Quick note: follow coding standards.
Here are some that the automated tool found:
http://ventral.org/pareview/httpgitdrupalorgsandboxjerrylow1966786git

Don't use hook_init() to load your css/js - this will load them on every Drupal request. Try and load them where they are actually needed, when the user is interacting with a term tagit enabled field. The same with require_once dirname(__FILE__) . '/terms_tagit.inc';. You should also check to make sure curl() exists before using it, or switching to drupal_http_request() instead.

jquery.autocomplete.js and jquery.tagsinput.js appear to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

----
Top Shelf Modules - Enterprise modules from the community for the community.

I think you should remove them for now. You could include patches that modify the Javscript libraries directly - that way you'd end up with the same code but not need to include anyone else's library. Instructions for downloading, unpacking, and patching those libraries should then go into your README or INSTALL.txt file.

Please set this issue back to "needs review" when you are ready.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Good to see that you corrected coding standard issues[http://ventral.org/pareview/httpgitdrupalorgsandboxjerrylow1966786git]. I've done a manual review, code looks clean. A few minor comments:

• README.txt line 16: "- Field type: term refernce" - missing e
• terms_tagit.module, function terms_tagit_libraries_info() - under variants->minified, you should add the minified version of the js, since it exists in the library folder [if that was done on purpose - "I'm using the non compressed js version" refers to this - disregard comment]
• I think you should mention in the README.txt, that the jQuery-Tags-Input library folder should be named tagsinput, since the package comes with the jQuery-Tags-Input directory name, and it's not that obvious if you don't look into the code

These are,of course minor things which are not application blockers.

Also I'll probably post a feature request: it should be awesome to see such UI improvements in a Views exposed filter!

In terms_tagit_json_view() you're not doing any access checks to make sure the user actually has access to the taxonomy vocabulary. Setting to needs work for that, other this looks ready to me. Thanks for switching to Libraries and removing the 3rd party code.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Hmm, that's weird, I coulda sworn there were permissions for that. Your solution looks reasonable though, thanks!

Thanks for your contribution, jerrylow!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

https://drupal.org/project/autocomplete_deluxe

This sounds like a feature that should live in the existing autocomplete_deluxe project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the autocomplete_deluxe issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

You still got the git vetted user role, but I would strongly recommend to consider collaboration with an existing module before promoting yet another module of this kind.

It looks like you're using the jquery library and they have a custom js solution.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.