[D7] Profile2 XMLSitemap

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, module should have a README.txt with the usage and any relevant thing about the module.

Read more in http://drupal.org/node/1587704 "5.2 Ensure the repository contains a detailed README.txt."

ooh always fun, xmlsitemap!

Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Automated errors
http://ventral.org/pareview/httpgitdrupalorgsandboxmakangus1783144git

FILE: /var/www/drupal-7-pareview/pareview_temp/profile2_xmlsitemap.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/profile2_xmlsitemap.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
38 | ERROR | Missing parameter type at position 1
94 | ERROR | Missing parameter type at position 1
--------------------------------------------------------------------------------

General
Looks nice and clean! No errors and clear functionality.

Looks awesome, PAReview comes out clean now and everything works as expected. I think we can call this RTBC :)

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

manual review:

• profile2_xmlsitemap_entity_insert(): If you are interested in only one entity type then you should implement hook_profile2_insert(). Same for the other entity level hooks that you only need for profile2.

But that is not a blocker, so ...

Thanks for your contribution, makangus!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.