As discussed on development list, this patch removes 4.7 - 5.x updates. Untested.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webernet’s picture

Status: Needs review » Needs work

- Needs to keep updates-5.x-extra (1022)
- Needs to update the relevant line in the changelog.

catch’s picture

Status: Needs work » Needs review
FileSize
17.06 KB

Yes, and yes.

Gábor Hojtsy’s picture

I tried to direct people to here from the mailing list. Let's see what they'd like to add.

Crell’s picture

As stated on the mailing list, I'd prefer that we keep a "full supported" set of upgrade functions. That is, Drupal 6 has upgrade functions for 4.7->5 and 5->6, D7 has upgrade functions from 5->6 and 6->7, etc. There will be people trying to make a 2 version jump and for non-complex sites (those most likely to not be kept up to date anyway) that's probably easier than doing it in stages, since you only have to upgrade custom code or custom themes once.

Older than that, I agree, no sense maintaining it in core.

catch’s picture

Unless I'm missing something, the only extra work required is:

wget and unpack drupal-5.x tarball
copy/edit settings.php
run update.php
remove the folder ready for D6 tarball

As KarenS pointed out on the development list, it will be necessary to install and upgrade cck 5.x as well if present in 4.7 - this adds one or two steps to the above in those cases. There's no reason to upgrade custom code and themes as far as I can see, at all, custom modules and themes (and php blocks) should be disabled when running the updates anyway.

Gábor Hojtsy’s picture

I looked up what did we suggest earlier:

http://drupal.org/drupal-5.0 :
For the most trouble free transition, it is recommended that you first upgrade existing installations to Drupal 4.7.

http://drupal.org/drupal-4.7.0 :
For the most trouble free transition, it is recommended that you first upgrade existing installations to Drupal 4.6.

http://drupal.org/drupal-4.6.0 :
For the most trouble free transition, it is recommended that you first upgrade existing installations to Drupal 4.5.

http://drupal.org/drupal-4.5.0 :
For the most trouble free transition, it is recommended that you first upgrade existing installations to Drupal 4.4 and only then to Drupal 4.5.

http://drupal.org/drupal-4.4.0 :
First, for the most trouble free transition it is recommended that you first upgrade existing installations to Drupal 4.3.0, Drupal 4.3.1 or Drupal 4.3.2.

All in all, it looks like this "recommendation" is in place since Drupal 4.4.0 although we did not make this a requirement ever.

Warning, tired procrastination fun follows:

http://drupal.org/drupal-4.3.0 :
no info on upgrades, but "With this installment, specific focus has gone into improving user-friendliness, both to end-users and administrators." woot-woot :)

http://drupal.org/drupal-4.2.0 :
no info on upgrade, but "Support for Microsoft SQL server." woot-woot

http://drupal.org/drupal-4.1.0 :
no info on upgrade, but look at http://drupal.org/image/tid/7?page=0 :)

http://drupal.org/drupal-4.0.0 (this is unpublished for some reason):
no info on upgrades, but thats a press release! a press release!

no node found for Drupal 3.0.0, actually, the first nodes on drupal.org are later then the 3.0 release.

BTW I actually set the aliases for these nodes as I went down from 4.4.0 which was long ago enough, that it did not have an alias, and none of the earlier nodes had.

Gábor Hojtsy’s picture

catch: you would actually need to update most of your contrib modules in two stages, as it is quite likely that more contrib modules follow suit if we enforce what we did recommend for a few years now.

catch’s picture

Status: Needs review » Needs work

Just found these three functions in update.php that ought to also be removed by this patch:

function update_fix_schema_version()
function update_fix_sessions()
function update_fix_watchdog_115()

hswong3i’s picture

Subscribe

hswong3i’s picture

Status: Needs work » Needs review
FileSize
30.37 KB

I found that some more functions should also remove, beside listed in #8:
function update_fix_watchdog()
function update_fix_system_table()
function update_fix_access_table()
function update_convert_table_utf8($table)
function update_create_cache_tables()

hswong3i’s picture

Title: Remove 4.7 updates » remove legacy updates
Gábor Hojtsy’s picture

Status: Needs review » Needs work

Patch needs to be updated, as #200271 was committed.

hswong3i’s picture

Status: Needs work » Needs review
FileSize
23.86 KB

Patch via latest CVS HEAD.

hswong3i’s picture

Title: remove legacy updates » remove legacy 4.7 - 5.x updates
FileSize
23.88 KB

Patch via latest CVS HEAD.

scor’s picture

Title: remove legacy 4.7 - 5.x updates » remove legacy 4.7.x to 5.x updates
FileSize
23.88 KB

needed a reroll.

hswong3i’s picture

I diff #14 and #15, but seems no different?

scor’s picture

with #14 I had Hunk #1 FAILED at 1039 for modules/system/system.install

hswong3i’s picture

@scor: Oh you are right. I test #15 with latest CVS HEAD, all pass :-)

catch’s picture

Status: Needs review » Reviewed & tested by the community

#15 still applies cleanly, tested by hswong3i, so back to rtbc.

I will note this saves 500kb of memory during the upgrade from 5.x - 6.x (and possibly the same at install time) according to scor on another issue, which is currently occupying two release blockers.

scor’s picture

Status: Reviewed & tested by the community » Needs review

The estimation I gave earlier was approximate, and after retesting this on install and update on 2000 node site, I notice that we only save about 100KB, not more. is it worth removing the older updates then?

catch’s picture

Status: Needs review » Reviewed & tested by the community

We're removing the updates not to save memory, but to clean up the code base (and to prevent unsupported upgrades and associated support requests). It's a shame there's not much additional bonus, but that was never the original intent of this issue. Whether those updates are removed or not is up to the core committers, but the patch does the job.

hswong3i’s picture

Title: remove legacy 4.7.x to 5.x updates » Siren #13: remove legacy 4.7.x to 5.x updates
Assigned: Unassigned » hswong3i

@catch: +1. I guess the most safe upgrade procedure is follow our tradition as state in #6: as a normal user, this instruction should be enough clear; from a point of view of developer, we can keep our main focus in the correctness of upgrade from previous version ONLY, so simpler and less buggy.

P.S. sorry for changing issue title, as I am now trying to collect similar issues for a simpler tracing.

chx’s picture

Title: Siren #13: remove legacy 4.7.x to 5.x updates » remove legacy 4.7.x to 5.x updates

As Siren is not a project on Drupal.org but an unofficial fork, I am removing it from issue titles to avoid confusion.

Dries’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, the patch no longer applies and needs a quick reroll.

hswong3i’s picture

FileSize
23.88 KB

Here it is.

Gábor Hojtsy’s picture

Status: Needs work » Fixed

Committed, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.