[D7] Subscriptions by Reference [#1990672]

This project is an extention to Subscriptions module which allows
users to subscribe to new content via reference fields.

View code: http://drupalcode.org/sandbox/bulat/1990654.git
Repo: git clone http://git.drupal.org/sandbox/bulat/1990654.git subscriptions_reference
Reviews of other projecst:

Sample use case

There are two content types Answer and Question and each Answer references
specific question via node reference or entity reference field;
As a user I want to subscribe to a Question, which means that every new Answer related to that question will be mailed to me.

For developers

We only need to implement hook_subscriptions_reference_info() provided by this module for above use case to work:


/**
 * Implements hook_subscriptions_reference_info()
 */
function example_subscriptions_reference_info() {
  return array(
    'question_answers' => array(
      'parent' => 'question',
      'child' => 'answer',
      'field' => 'field_question', // field on answer content type that references a question
      'ref_item' => 'nid', // this will be 'target_id' for entity reference
  ));
}

Sandbox

Link to sandbox project - http://drupal.org/sandbox/bulat/1990654

Need for project

This functionality was discussed here - #286789: Sending notifications based on a cck node reference field

Test coverage

This project includes fair amount of tests, which can be of use for Subscriptions module.

Comment	File	Size	Author
#6	coder-results.txt	8.93 KB	klausi

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

PA robot CreditAttribution: PA robot commented 9 May 2013 at 04:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxbulat1990654git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #2

bulat CreditAttribution: bulat commented 9 May 2013 at 21:10

Status:

Needs work

» Needs review

Code in the module was fixed according to automated review in comment #1. Some issues are still pending in test files, but that should not affect the review of the module.

Comment #3

bennetteson CreditAttribution: bennetteson commented 10 May 2013 at 10:37

Please use ready to use public git clone without your usename :
git clone http://git.drupal.org/sandbox/bulat/1990654.git subscriptions_by_reference

Comment #3.0

bennetteson CreditAttribution: bennetteson commented 10 May 2013 at 10:37

Issue summary:

View changes

Added link to repository

Comment #3.1

bulat CreditAttribution: bulat commented 10 May 2013 at 10:46

Issue summary:

View changes

updated clone command

Comment #4

bulat CreditAttribution: bulat commented 10 May 2013 at 10:48

Updated git clone command.

Comment #4.0

bulat CreditAttribution: bulat commented 10 May 2013 at 10:48

Issue summary:

View changes

updated clone folder

Comment #4.1

bulat CreditAttribution: bulat commented 10 May 2013 at 10:50

Issue summary:

View changes

Added review http://drupal.org/node/1930370#comment-7186314

Comment #5

bulat CreditAttribution: bulat commented 15 May 2013 at 20:38

Issue tags:

+PAreview: review bonus

PAReview tag added.

Comment #6

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 18 May 2013 at 17:05

Status:	Needs review	» Reviewed & tested by the community
Issue tags:	-PAreview: review bonus

File	Size
coder-results.txt	8.93 KB

Review of the 7.x-1.x branch:

Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

DrupalPractice has found some issues with your code, but could be false positives.


FILE: /home/klausi/pareview_temp/subscriptions_reference.test
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
   6 | WARNING | Class name must be prefixed with the project name
     |         | "subscriptions_reference" (omitting underscores)
 239 | WARNING | Are you accessing field values here? Then you should use
     |         | LANGUAGE_NONE instead of 'und'
 247 | WARNING | Class name must be prefixed with the project name
     |         | "subscriptions_reference" (omitting underscores)
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

project page is too short, see http://drupal.org/node/997024
So the reference fields only work on nodes, right? Maybe clarify that in the README.txt?

Can't say much about the functionality of the module, but looks RTBC from visual code review. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Comment #7

bulat CreditAttribution: bulat commented 23 May 2013 at 21:47

I fixed most code issues in .test file, updated project's page and ReadMe file.

Comment #8

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 15 June 2013 at 08:01

Status:

Reviewed & tested by the community

» Fixed

Hm, this has fallen off my radar, sorry about that. No objections for more than a week, so ...

Thanks for your contribution, bulat!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.