[D7] Password Recovery Panels Widget

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated review
http://git.drupal.org/sandbox/cravecode/2005178.git
no errors found

Manual review

Just a suggestion:
Line 14: password_recovery_widget.pages_default.inc
Won't it be better to make html output themeable rather then to assign it directly inside the code?

That's all for now.

Nice module! I want to review it and learn the ctools API at the same time. When I tried to use it I saw the following problem:

I left the "Textfield Label" and "Button Label" fields empty and got the following notices:

Notice: Undefined index: password_recovery_widget_field_label in PasswordRecoveryPlugin::renderBlock() (line 68 of /home/web/drupal/sites/all/modules/temp_reviews/2005178/lib/PasswordRecoveryPlugin.php).
Notice: Undefined index: password_recovery_widget_submit_label in PasswordRecoveryPlugin::renderBlock() (line 69 of /home/web/drupal/sites/all/modules/temp_reviews/2005178/lib/PasswordRecoveryPlugin.php).

It seems you don't validate input (or provide defaults) for these fields.

I'll continue studying your module, but if you want others to review it change the status to "need review".

Review of the 7.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/lib/PasswordRecoveryPlugin.php
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   7 | WARNING | Class name must be prefixed with the project name
     |         | "password_recovery_widget" (omitting underscores)
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. password_recovery_widget_menu_alter() and password_recovery_widget_preprocess_link(): not sure every site would want to completely disable user/password, I think that should be configurable in your module.
2. why do you need the PasswordRecoveryPlugin class, it does not wrap any behaviour? Using a class like that does not make sense, you could as well just implement the plugin functions?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, cravecode!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.