Not sure yet when I'll get to this, but I thought I could share some ideas:
- The port will be a great opportunity to improve performance, thanks to improvements that have been achieved in the core search (for example, we'll get rid of a temporary database table).
- I'm not too happy with the faceted_search_variables table. It was a quick way to get up and running with multiple search environments, where facet modules could easily add their own per-environment settings. Although improving the variables system is not an absolute requirement for the port to D6, the Schema API should make it almost as easy as the current system to manage module-specific persistent variables, but with a much cleaner data structure.
| Comment | File | Size | Author |
|---|---|---|---|
| #90 | faceted_search_views.patch | 3.73 KB | bugster |
| #69 | faceted_search_unofficial_no_69.zip | 342.54 KB | francewhoa |
| #60 | faceted_search_views.info_.patch | 646 bytes | brianV |
| #59 | faceted.jpg | 11.21 KB | mfricke |
| #58 | Faceted_Search_6_x_unofficial_no_58.zip | 350.89 KB | francewhoa |
Comments
Comment #1
zilla commentedhello david - this module is amazing, and i *think* it may be in use at ostatic.com (om malik's new open source site)...
i was wondering what the status of hte d6 release looks like - i'm more than happy to test out a dev roll-up if you wind up posting it to the project page...
Comment #2
zilla commentedhi, sorry to pester, just wondering if this is still on its way to drupal 6 - would love to use it! happy to test and screw around with it if and when there's a dev or beta..
Comment #3
David Lesieur commentedUnfortunately, I did not have time yet to work on the D6 port... But an update will be posted here whenever progress is made. ;)
Comment #4
zilla commentedthanks david, looking forward to seeing it! this kind of search and drilldown is truly the most intuitive way to deal with large content sites on drupal built around large taxonomies and multiple vocabularies...very cool stuff.
Comment #5
David Lesieur commentedI am currently in the process of cleaning up/refactoring the query building logic, particularly around the keyword search. This should lead to the removal of a temporary table, as has been done in Drupal 6 core. Ultimately, this will also help with the D6 port.
Comment #6
francewhoaSubscribing
I agree with zilla I have tried all search related modules and for my project Faceted Search is
I'm actually using it with Drupal 5.7 and would like to use it with Drupal 6 too.
Awesome module thanks David.
Comment #7
killes@www.drop.org commentedis there anything one could do to help with the port?
Comment #8
Macronomicus commentedTwo thumbs up for the 6.x port!
Comment #9
whereisian commentedSubscribing. Looking forward to seeing this brilliant module in D6.
Comment #10
Macronomicus commentedJust checking in to see how your getting on. I'm quite excited to see/test this for 6.x! I am missing this module much since I switched to 6.x..... been using taxonomy_browser as a temporary fix; but it pales in comparison to your quite excellent much anticipated creation!
Please let us know if you need any help!
Cheers!
^_^
Comment #11
David Lesieur commentedActually, funding would help... If anyone has a budget for this work, please contact me.
Comment #12
DenRaf commentedI started the port to drupal 6. The basics are working for me. Just the Faceted Search Views and Field Keyword Filter plugins will not work for sure.
I will post my progress on my blog for sure: http://www.denraf.be/content/facetedsearch-module-drupal-6
The patch is against HEAD.
Comment #13
David Lesieur commentedAwesome! I've started reviewing the patch.
Because this is a big patch, unless there are major problems with it I'm likely to commit it so we can refine the code from CVS HEAD. Otherwise, I'm afraid the patch would be hard to maintain as the module continues to evolve.
Thanks!
Comment #14
David Lesieur commentedThere was a fatal error (Unsupported operand types in includes/common.inc on line 1269) when selecting a term from the Guided search, which is fixed in the attached patch (a call to url() was not updated with the new array argument). I've also fixed a few cosmetic details.
Still, the results page is always empty at the moment. This qualifies as a major issue preventing me from committing the patch...
Two other issues in this patch that will also need to be solved:
Comment #15
fasdalf@fasdalf.ru commentedI use windows so i can't apply patch. Could someone post here patched module for windows'users?
Comment #16
David Lesieur commentedPlease see Howto: Apply patches on Windows. Personally, I use Cygwin.
Comment #17
DenRaf commentedHere a new patch. The results do show up now.
When you want to use the serial type, we'll need to redesign the db schema.
The old_element_sort is now moved to a template file and is not in a function anymore.
You can test it at my blog (http://www.denraf.be)
Comment #18
niklp commentedSubscribing (apologies)
Comment #19
Wimmmmm commentedHi, Raf & David,
I noticed that hierarchical taxonomies are not (yet) supported in the port to 6.
I have a "locations" tax, with provinces in the root, and "area's" below each province.
When viewing my faceted list, I get all terms in the facet, not just the root provinces.
When choosing a province in the facet, I also expect to see my selection plus the areas in that province, but port shows no further refinement.
Bug or feature?
Comment #20
David Lesieur commented@WimJanin: Thanks for the report. These problems are bugs... So the patch still needs work.
Comment #21
henry_searle commentedHi guys,
Excellent work on getting this patch done.
I've only had one major problem with it where if I type something into the keyword search nothing happens.
If you manipulate the url you can get it to search but it doesn't show what you've typed in so the user won't necessarily know that its worked.
Plus the user would have to change the url to change.
I've been looking through the code but don't really know enough about the module, Drupal or php to come up with a solution to this.
Thanks again
Comment #22
elly commentedHiya - I tried to apply the patch and got a ton of errors. Should I be trying to patch the release from the main project page, or should I bet trying to patch HEAD?
Comment #23
dydecker commentedsubscribing
Comment #24
catorghans commented#22 same here
Comment #25
David Lesieur commentedNormally the patch must be applied to HEAD, but I have not reviewed the last patch. Also, it could be that it does not apply anymore because HEAD has changed since the patch was posted.
Comment #26
catorghans commentedIf I look at the dates your last suggestion is probably right.
Isn't it time for a D6 dev version? Or do you want to have a 1.0 for 5 before a real port to 6 is started?
Comment #27
David Lesieur commentedI would not mind releasing a D6 version before a 5.x-1.0 version. I'm just too busy with other work at the moment to work on the D6 port.
Issues have been reported regarding the last patch, so there is some clear work to do for anyone who's interested. Good code reviews and tests can also help.
Comment #28
francewhoaI can provide tests for D6 version.
Comment #29
David Lesieur commentedI have committed the patch #17 (with some changes), so we have a better basis for polishing the details.
Some to do items:
Comment #30
francewhoaHEAD version of Faceted Search for Drupal 6.x can be download at: http://drupal.org/node/145191
Comment #31
francewhoaHere are my testing results with faceted_search 6.x-1.x-dev (Last updated: August 26, 2008 - 05:04) downloaded from this page. Using a Drupal 6.4 fresh intall and Devel module to quickly generate dummy content. Tested on all major browsers: Firefox 3.01, Opera 9.52, Safari 3.11 & IE 7.
The good news:
The bad news:
[EDIT: fixed by DenRaf in comment #56:]
Sub-module Field Keyword Filter are incompatible with the 6.4 version of Drupal core. To reproduce install module faceted_search then visit module admin page. A red X will show. Attached screenshot (1_incompatible.png).With Guided Search content created by anonymous users is not clickable. Expected result is to be able to click on a link to initiate a search. Link could be something like 'anonymous (24)'. Attached screenshot (2_author_anonymous.png).On Faceted Search admin page when clicking Save and edit button we get redirected to the wrong page. To reproduce visit Administer > Site configuration > Faceted search > Click on Save and edit button. Then we get redirected to:
http://mywebsite.com/admin/settings/faceted_search1
Expected redirection should be to stay into the same page:
http://mywebsite.com/admin/settings/faceted_search/1
We notice in the above first link that the slash '/' before the 1 is missing. Attached screenshots (3a_Save_and_edit_Button.png & 3b_RedirectToWrongPage.png).
Rebuild the Taxonomy Facets index link return fatal error. To reproduce visit Administer > Site configuration > Faceted search > Click on rebuild the Taxonomy Facets index link. Then the next screen will return the following fatal error:
Unsupported operand types in /mywebsitepath/includes/common.inc on line 1275
Expected result is a next screen with a confirmation message. Attached screenshots (4a_rebuild_the_Taxonomy.png & 4b_fatal_error_rebuild_tax.png).
Keyword search does not work but this can be ignore for now because above post #29 do mention that 'Keyword search does not work'.Hope this testing help.
The following are notes to myself for future reference. Before using Faceted Search I must run cron and re-index the site. Otherwise search won't work properly:
Comment #32
David Lesieur commentedWow! Thanks for this detailed report! That provides good directions for anyone who would like to help with the port.
Comment #33
David Lesieur commentedAnother bug: The "Related Categories" block is broken — categories are either wrong (e.g. Date Authored facet) or do not show up (e.g. Content Type facet, Author facet).
Comment #34
james.nadeau commentedI would like to use this module for a search function to a new plant finder drupal site for garden.org. Our writers have already entered a good amount of content(cck fields and nodes) to test this search on. I look forward to getting this to work with drupal 6.4. Thanks to everyone before this who have given me some leads on where to start!
I'm going to look into getting the keyword search working as that is what is really important to our organization. Any helpful tips are appreciated.
I have moderate experience as a php programmer and drupal developer, but this will be some of the first work I'll be doing on a module of this complexity and one I haven't created from scratch. Wish me luck!
ps David, this is an awesome module, great work
Comment #35
Anonymous (not verified) commentedsubscribing
Comment #36
chasz commented+1
Comment #37
Rosamunda commented+1 subscribing!!!
Comment #38
keithmorr commentedsubscribing
Comment #39
korayal commentedsubscribing
Comment #40
niklp commentedJust changing this so it's better visible in tracker pages.
Comment #41
no2e commentedsubscribing
Comment #42
regi.bradley commentedsubscribing
Comment #43
jseffel commentedSubscribing.
Comment #44
ajross commentedsubscribing
Comment #45
DenRaf commented@Onopoc: thank you for the very detailed testing. Was very helpfull.
I've created a patch that fixes 1, 3 and 4. For 1, I just make it possible to enable it, did not test these functions.
I've been working on 2 already, but just not there yet.
The patch is against faceted_search-6.x-1.x-dev.tar.gz of 2/09/08
Comment #46
ianchan commentedsubscribing
Comment #47
DenRaf commentedK, also issue 2 is fixed. It took al lot of debugging to find it, but as you can see in the patch it are only minor changes.
Comment #48
francewhoaGreat. Thanks DenRaf. I'll try to test your patches this weekend.
Comment #49
root_of_roots commentedtesting and subscribing
Comment #50
gerhard killesreiter commentedHere's an updated patch which fixes a couple of notices and makes the keyword search work.
Comment #51
gerhard killesreiter commented_Here_ it is
Comment #52
David Lesieur commented@DefRaf & Gerhard: Excellent work! I just committed the patch #51. However, I have added missing t()'s and I haven't included the changes to faceted_search_views.info since that module is not Views 2-ready.
Keyword search now works, and the issues reported by Onopoc in #31 are all fixed, except the first one (incompatible sub-modules).
Summary of known bugs and tasks left to do:
Comment #53
francewhoa@DefRaf, Gerhard & David: Thanks for all the patches.
Here are my testing results with current HEAD faceted_search 6.x-1.x-dev (September 28, 2008 - 05:04). Hope this help.
The good news:
The bad news:
To reproduce:
I didn't test Faceted Search Views because it's still under development. I'll test when it's ready.
Testing done with:
Comment #54
clems commentedThanks for porting this great module to Drupal 6. Does anyone have a patch or any sort of info on how to port the remaining sub-modules Search Views and Field Indexer to v6? I absolutely need those.
Comment #55
root_of_roots commented@clems
Might try Deadwood . It may work out of the box, but often it requires a little to a lot of modifying. A couple of modules I tried with this worked - but not 100%.
Comment #56
DenRaf commentedQuick patch here to fix issue mentioned in #53 as also to make it possible to enable the field_keyword_filter module since I made a quick port of the field_indexer module.
Comment #57
David Lesieur commentedComment #58
francewhoaIf someone else wants to help with testing or development here is the module Faceted Search for Drupal 6.x unofficial #58. Made with patch #56 applied against current HEAD faceted_search 6.x-1.x-dev (September 28, 2008 - 05:04). Important: This is an unofficial version and it should be install only on test or development server NOT on production (live) server. Enjoy.
@DenRaf : Thanks for patch on #56. I tested it and sub-module Faceted Field Keyword Filter is now compatible with the 6.4 version of Drupal core.
I haven't tested yet your quick port of the Field Indexer module. When done I'll create another comment with my results at this page.
Patch on #56 fixes only part of issue #53 though. The good new is that searching for the number zero '0' will return a result. But the bad news is that the result is mixed with all available data. Attached screenshot (2_zero_issue.png). To reproduce:
Expected result is to return only the page created at step 2. The page with the zero. Attached screenshot (2_zero_expected.png). This screenshot is a search result with number one '1' instead of '0'. Hope this help.
Task left to do if someone else wants to help:
Comment #59
mfricke commentedUsing drupal 6.5, I am getting the following error warning on every update of content: that line 192 of the taxonomy_facets.module uses an invalid argument (screenshot attached). I am not immersed in this but I will try to have a look.
Good work!
Martin
Comment #60
brianV commentedFaceted Search Views is now compatible once the attached patch is applied.
There were some syntax errors that needed to be cleaned up in faceted_search_views.info.
Module is only half-ported - working on fixing some remaining bugs....
**Edit** What needs to be done to do this module 'right' somewhat exceeds my time and views knowledge at this point. Perhaps someone more familiar with the Views2 API would like to take a crack at it...
Comment #61
elioshsubscribe, sorry :-(
Comment #62
jazic commentedthanks, will give the latest a test.
Comment #63
elioshToday's test :
I have a complete vocabulary for Italian's regions, province and cities. The hierarchy is like this :
If i tag a node with a city, with faceted search in D5 i can browse starting from Region, than select the province and so the city (you can try this on www.youitaly.it).
Now, with D6, i repeat the same step as D5. Imported the same vocabulary, but now faceted search show me only the city.
I try to change "hierarchy" field in database table "vocabulary" from 0 to 1, but with the value "1" it doesn't work at all.
I hope i was clear.
Is there anything i made wrong ?
The version of FS i'm using is 6.x-dev of 21/10/2008. Drupal is the latest (6.5)
Thanks
Comment #64
pisco23 commentedsubscribe
Comment #65
kulvik commentedGreat work guys! I'll jump in and help test this.
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no
+47 4000 7955
Comment #66
dropchew commentedSeems like 6.x doesn't work with views 2, cant seem to find the arg for facted search environment id in views 2...
Comment #67
OneTwoTait commentedsubscribe. :)
Comment #68
that0n3guy commentedSubscribed
So its my understanding that views does not work quite yet... is that still true?
Comment #69
francewhoaIf someone else wants to help with testing or development here is the latest module Faceted Search for Drupal 6.x unofficial version #69. Untested. Faceted Search Views should now be compatible. Made with patch #60 from brianV. Patch applied against current HEAD faceted_search 6.x-1.x-dev (October 20, 2008 - 17:05). Important: This is an unofficial version and it should be install only on test or development server NOT on production (live) server. Enjoy.
Comment #70
decibel.places commentedI'm using faceted search on D6 to expose some taxonomy categories for a certain role "buyer" as well as search the content
Not using Views or anything else fancy, it's working fine for what I need, using faceted_search-6.x-1.x-dev.tar.gz
It's a closed site, used for tracking leads from web campaign ads for various clients, using webforms, ThemeKey (really handy, for paths created with taxonomy + pathauto) and additional stats by GA, Woopra and Clicky.
Comment #71
coconnor commentedSubscribing...
Comment #72
scott859 commentedSubscribing...
Comment #73
David Lesieur commentedHi, I have been a bit quiet lately, taken over by other projects. Thank you all for your contributions (and your patience!). Your work has allowed many people to get started with Faceted Search on Drupal 6! I'll soon be able to put more time on Faceted Search, and I hope to release a solid Drupal 6 version early next year.
Comment #74
Bilalx commentedGood to hear that, we are waiting :)
Comment #75
chawl commentedWhy not use as a menu system ;)
Tx for an excellent drilldown solution.
subscribing.
Comment #76
chawl commentedSorry ...
Comment #77
David Lesieur commentedBtw, there is no difference between the current dev version and Onopoc's version (#69), except for the changes to faceted_search_views.info. However, those changes are insufficient to make Faceted Search Views work with Views 2. I won't update the info file until the module really works.
Comment #78
David Lesieur commentedI have begun working on major changes to address issues mentioned in #52. I might be able to deliver results in a few days.
Comment #79
David Lesieur commentedAs of today, the dev version should work pretty well with Drupal 6. The only major component that's still missing is Views integration.
Of course, everyone is welcome to test and report bugs/issues. :-)
Comment #80
jeromev commentedHey David,
I tried it yesterday evening, but could’nt get the “related gategories” block. I just downloaded the dev you just submitted, and boom! It works!!
Great job. I’ll let you know if I find any bug/issue.
Happy new year!
jv
Comment #81
storable commentedLove the search, but is there any way to make the URL more search engine friendly? my.website.com/fsearch/results/taxonomy:4711.3846,4301 is not exactly search friendly.
Thank you,
storable
Comment #82
David Lesieur commented@storable: this is discussed in #227627: Use term names and term ids in paths.
Comment #83
yurtboy commentedI got this error right after installing faceted unofficial
user warning: Table 'db.view_view' doesn't exist query: SELECT v.name FROM view_view v INNER JOIN view_argument a ON a.vid = v.vid WHERE a.type = 'faceted_search_results' ORDER BY v.name in /somepathhere/modules/faceted_search_unofficial_no_69/faceted_search_views.module on line 18.
Comment #84
David Lesieur commentedAt this point, please ignore the unofficial package that's been posted in this thread. Try the 6-x-1.x-dev package from the project's page instead.
Comment #85
mikeytown2 commentedK got it working on a live site... What can I do to help with getting the views submodule working?
http://www.bluediamondhomeandrv.com/
Comment #86
Junro commentedsubscribe
Comment #87
kpaul commentedany word on when Faceted Search Views will be compat with D6.8 and now D6.9?
thanks!
Comment #88
that0n3guy commentedHey all...
I am in need of views 2 integration but am no coder...
I thought I would post this: http://views.doc.logrus.com/
Its the doc's for views 2 api, maybe this will help give someone a boost.
Thanks for everyone's great work!
Comment #89
liliplanet commentedsubscribe, thx!
Comment #90
bugster commentedThis is a views2 patch, this is still WIP.
It will work if you patched the info file (dependency bug)
If you are using database prefixes then you will also need to patch the query function from the class faceted_search_query in the file faceted_search.inc.
You will have to put curly braces into the join for the heap table. ( wrapper_begin and wrapper_end )
in the default view you will have to provide a pager
Berry.
Comment #91
mikeytown2 commentedPatch Does Work, tested on my local machine. I want to get Faceted Search working with boost before I roll this out on my live site.
Comment #92
David Lesieur commentedNice! I haven't tried it yet, but here are some quick comments on the code:
db_query("SELECT name FROM {views_view} ORDER BY name");call.Comment #93
mikeytown2 commentedK got it working with boost and views, so its now live. Only Manufactured Homes and Used have it
http://www.bluediamondhomeandrv.com/
but if you want to browse it all here's the "secret" faceted entrances that exposes all
http://www.bluediamondhomeandrv.com/manufactured-homes
http://www.bluediamondhomeandrv.com/pre-owned
Comment #94
mcreature commentedSubscribing
Comment #95
sunfish commentedI'm trying to display search results using a custom view defined in Views2. Is Faceted Search a possible solution? If so, how do you make Faceted Search Views compatible with Drupal 6.9?
Comment #96
David Lesieur commented@sunfish: See the above patch (#90). I have not tried it yet, but mikeytown2 reported that it works for him.
Comment #97
sunfish commentedYes, it does seem to work. The only thing is Field Keyword Filter cannot be enabled becasue Field_Indexer is missing.
Is it possible to include a plain vanilla keyword search block a la drupal default search block?
Comment #98
mikeytown2 commented@sunfish
http://drupal.org/project/autocomplete_node_finder
Comment #99
David Lesieur commented@sunfish: Field Indexer is a separate module: http://drupal.org/project/field_indexer.
Comment #100
jeromev commentedPatch #90 works great. Thanks Berry!
jv
Comment #101
playfulwolf commentedsubscribe
Comment #102
mudd commentedSubscribe
Comment #103
doughold commentedsubscribing
Comment #104
David Lesieur commentedAlthough bugster's version (#90) was a good start and properly filtering the search results, it was not complete since the guided search was not taking the view's filters into account.
I have just completed this work and committed it. I have also removed the unnecessary
faceted_search_views_views_api()function, changed the view retrieval to use Views' API and to only select appropriate views, made some code simplifications, and fixed code style issues.The README.txt file has been updated with new instructions for Views integration.
The port of Faceted Search to Drupal 6 and Views 2 is now complete!
Comment #105
Junro commentedThanks ^^ Congratulations! Great job :)
Comment #106
salaDDodger commentedGreat Work!! Thank You so much :)
Comment #107
doughold commentedJust in time! I was struggling with the views integration yesterday afternoon, and vualah, a beta release with everything working beautifully that night! Thanks guys!
Comment #108
elioshGreat David, and thanks to everybody who works on this issue.
Comment #109
kpaul commentedsorry about that...
Comment #110
mikeytown2 commented@kpaul, open a new issue for your question. This thread is marked as fixed.