When a comment with a vote is deleted, the user's vote stays.
The user can then make a new comment with a new vote, but the new vote is not counted for the page (although still displayed above the comment).

CommentFileSizeAuthor
#15 fivestar-comment-delete-insert.patch1009 bytesNick Lewis

Comments

quicksketch’s picture

Thanks, looks like a bug introduced in 1.12 for Drupal 5. I'll have a look.

quicksketch’s picture

Oh.. and 6 too. Dang. Problems in both places.

quicksketch’s picture

Status: Active » Fixed

This should now be fixed, you can grab the patch from:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/fivestar/fi...

Or wait for 1.13.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

userofdrupal’s picture

Version: 6.x-1.12 » 5.x-1.12
Category: bug » support

How can I manually delete the ratings safely? Either sql or php if the api supports deleting votes.

off’s picture

when the new version comes?

off’s picture

Status: Closed (fixed) » Active
quicksketch’s picture

Status: Active » Fixed

It'll come when the issue queue is cleared of all the current bugs. This issue is fixed, the 1.13 version just hasn't come out yet.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

FuXXz’s picture

But i have still this problem with drupal6! If i delete the comment the votes are still save in tables and show up in the fivestar

FuXXz’s picture

It there any solution for this problem i still have?

FuXXz’s picture

2 Years ago i reported this bug, and now i want to use the modul again and this bug is still alive

Drupal 6.17, Fivestar 1.19 :(

FuXXz’s picture

Version: 5.x-1.12 » 6.x-1.19
Category: support » bug
FuXXz’s picture

Status: Closed (fixed) » Active
Nick Lewis’s picture

Status: Active » Needs review
StatusFileSize
new1009 bytes

This seems to fix the issue. The problem was that in inserts and updates it was using an old data structure so vote_ids were being recorded as "0" in the fivestar table :-S.

Sorry, don't have time to patch against CVS so i just made a patch against the fivestar directory.

Exploratus’s picture

The patch seems to have worked, but it doesnt work for existing votes in queue, only new ones..

Furthermore, I think Fivestar should not count a vote until the comment is approved, which it doesnt do now. Votes are counted as soon as they are submitted...

markus_cz’s picture

Thanks for the patch, Lewis, I'll try it and see if it works.

By the way, is there any way to manually delete the "orphaned" votes? I tried browsing the database but found no order in the votes - I was unable to find anything that would identify votes that don't have comments assigned. Perhaps I just looked in wrong places?

joshdean’s picture

This patch resolves the issue. Please apply to the patch to the main repository.

YK85’s picture

Status: Needs review » Reviewed & tested by the community

Subscribing, thanks for the patch. Hope it gets reviewed by the maintainer and committed soon. Many thanks!

vkareh’s picture

Status: Reviewed & tested by the community » Closed (duplicate)