Download & Extend
Fivestar » Issues

Deleting a comment does not delete the attached vote.

Posted by RoboPhred on April 22, 2008 at 12:24am
Project:Fivestar
Version:6.x-1.19
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)

Issue Summary

When a comment with a vote is deleted, the user's vote stays.
The user can then make a new comment with a new vote, but the new vote is not counted for the page (although still displayed above the comment).

Login or register to post comments

Comments

#1

Posted by quicksketch on April 27, 2008 at 2:30am

Thanks, looks like a bug introduced in 1.12 for Drupal 5. I'll have a look.

#2

Posted by quicksketch on April 27, 2008 at 2:30am

Oh.. and 6 too. Dang. Problems in both places.

#3

Posted by quicksketch on April 27, 2008 at 3:16am
Status:active» fixed

This should now be fixed, you can grab the patch from:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/fivestar/fi...

Or wait for 1.13.

#4

Posted by Anonymous (not verified) on May 11, 2008 at 3:21am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#5

Posted by overflowing on May 17, 2008 at 12:06pm
Version:6.x-1.12» 5.x-1.12
Category:bug report» support request

How can I manually delete the ratings safely? Either sql or php if the api supports deleting votes.

#6

Posted by OFF on June 13, 2008 at 3:30pm

when the new version comes?

#7

Posted by OFF on June 19, 2008 at 10:49pm
Status:closed (fixed)» active

#8

Posted by quicksketch on June 20, 2008 at 2:06am
Status:active» fixed

It'll come when the issue queue is cleared of all the current bugs. This issue is fixed, the 1.13 version just hasn't come out yet.

#9

Posted by Anonymous (not verified) on July 4, 2008 at 2:12am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#10

Posted by FuXXz on May 10, 2009 at 11:05pm

But i have still this problem with drupal6! If i delete the comment the votes are still save in tables and show up in the fivestar

#11

Posted by FuXXz on May 17, 2009 at 4:53pm

It there any solution for this problem i still have?

#12

Posted by FuXXz on June 22, 2010 at 5:02pm

2 Years ago i reported this bug, and now i want to use the modul again and this bug is still alive

Drupal 6.17, Fivestar 1.19 :(

#13

Posted by FuXXz on June 22, 2010 at 5:03pm
Version:5.x-1.12» 6.x-1.19
Category:support request» bug report

#14

Posted by FuXXz on June 22, 2010 at 5:03pm
Status:closed (fixed)» active

#15

Posted by Nick Lewis on June 23, 2010 at 6:21pm
Status:active» needs review

This seems to fix the issue. The problem was that in inserts and updates it was using an old data structure so vote_ids were being recorded as "0" in the fivestar table :-S.

Sorry, don't have time to patch against CVS so i just made a patch against the fivestar directory.

AttachmentSizeStatusTest resultOperations
fivestar-comment-delete-insert.patch1009 bytesIgnored: Check issue status.NoneNone

#16

Posted by Exploratus on July 24, 2010 at 6:58pm

The patch seems to have worked, but it doesnt work for existing votes in queue, only new ones..

Furthermore, I think Fivestar should not count a vote until the comment is approved, which it doesnt do now. Votes are counted as soon as they are submitted...

#17

Posted by markus_cz on August 9, 2010 at 12:15pm

Thanks for the patch, Lewis, I'll try it and see if it works.

By the way, is there any way to manually delete the "orphaned" votes? I tried browsing the database but found no order in the votes - I was unable to find anything that would identify votes that don't have comments assigned. Perhaps I just looked in wrong places?

#18

Posted by joshdean on November 8, 2010 at 4:05pm

This patch resolves the issue. Please apply to the patch to the main repository.

#19

Posted by YK85 on November 9, 2010 at 9:25am
Status:needs review» reviewed & tested by the community

Subscribing, thanks for the patch. Hope it gets reviewed by the maintainer and committed soon. Many thanks!

#20

Posted by vkareh on March 2, 2011 at 2:33pm
Status:reviewed & tested by the community» closed (duplicate)

Marked as a duplicate of #601160: Comment-cast ratings not deleted with comment.