Hi,

Is there any plan for d6 port ?

CommentFileSizeAuthor
#24 sms_4.patch25.45 KBWill White
#19 sms_3.patch24.29 KBAnonymous (not verified)
#13 sms_2.patch18.55 KBAnonymous (not verified)
#11 sms_1.patch9.76 KBAnonymous (not verified)

Comments

flickerfly’s picture

flickerfly commented
Title: D6 port ? » Port of SMS Framework to D6

Also interested

nmashruwala’s picture

nmashruwala commented

subscribing

TyraelTLK’s picture

TyraelTLK commented

subscribing

papasj’s picture

papasj commented

subscribing

tylor’s picture

tylor commented

This will likely be ported after we get a 1.0 release, for which I have a roadmap here: http://groups.drupal.org/node/12068

Biggest piece left is improvements to sms_user – just a few more tickets to close!

freakx0’s picture

freakx0 commented

subscribing

joe_k’s picture

joe_k commented

subscribing

Will White’s picture

Will White commented
Category: support » task
Priority: Normal » Critical

Moving to critical as this is a part of the 1.1 roadmap.

WiredRogue’s picture

WiredRogue commented

Very interested in a D6 version!

mandhdesign’s picture

mandhdesign commented

subscribing

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new sms_1.patch9.76 KB

Here you go... Included are:

  • port for sms.info (rev 1.2)
    • enables SMS Framwork module to be installed under Drupal 6.x
  • port for sms.install (rev 1.7)
    • now uses Drupal 6.x database scheme
    • now uses Drupal 6.x database scheme API functions
  • port for sms.module (rev 1.6)
    • now uses Drupal 6.x menu configuration
    • ported form theming/validation/submission

Patches are all created against HEAD.

With these patches the SMS Framework core module should be ported to Drupal 6.x. I haven't ported "Send to phone" and any gateway yet, these will follow soon starting with Clickatell. When these are ported, sending SMS messages to mobile phones can be tested.

EDIT: Added port for sms.install & combined patches into one single file.

tylor’s picture

tylor commented
Status: Active » Needs review

Thanks TheOnlyHarry, this patch is greatly appreciated; I tested and it seems to be working fine. Very much looking forward to seeing the other parts come together.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new sms_2.patch18.55 KB

Finished porting of "Send to phone" & Clickatell SMS gateway submodules. Sending messages using Clickatell should now be possible. As the Clickatell module only supports US phone numbers (which I don't have) it was not possible for me to actually send out an SMS. I did test authentication/communication with the Clickatell API though, and that seemed to work as expected. If someone is prepared to apply this patch and test if sending out an SMS message actually works that will be greatly appreciated.

Change summary:

  • sms framework core module
    • ported validation callbacks for gateway configuration form
    • ported submission/validation callbacks for "send sms" form
  • send to phone module
    • enabled module to be installed under Drupal 6.x
    • ported menu configuration
    • ported form configuration
    • ported Drupal API function calls
  • clickatell gateway module

Patch was created against HEAD and therefore replaces #252568-11: Port of SMS Framework to D6.

yhager’s picture

yhager commented

subscribing

Will White’s picture

Will White commented

Sending using Clickatell works. Thanks! I'll continue to test and work on the sms_user.module

Anonymous’s picture

Anonymous (not verified) commented

Ok, I'll start with SMS recieve then... Maybe I will give the other gateways a try also, but as I don't have an account with any of them i can only do so much. When are you planning to commit the current patch to CVS?

yhager’s picture

yhager commented

I forgot to mention: patch #13 applies cleanly, sending messages through clickatell works. I am not sure this is enough testing to mark as RTBC.

geodaniel’s picture

geodaniel commented

subscribe

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new sms_3.patch24.29 KB

Added port for sms_recieve module. Made the usual D6 modifications and the admin interface seems to be working fine, but reception of SMS messages was not tested. If anyone is using a specific gateway for receiving messages please post it's name here and I will port that module also, so we can do some end-to-end testing :)

To summarize, the following (sub)modules have been ported by me until now:

  • Clickatell
  • Send to phone
  • SMS Framework
  • SMS Receive

TODO

  • E-mail Gateway
  • Muse
  • SMS Organic Groups
  • SMS User (diggersf is working on that one)
Will White’s picture

Will White commented

sms_receive is in need of an overhaul. This will probably involve the use of the actions module to react to incoming messages. I've already begun writing preliminary code for this so I might not be worth including the current sms_receive module in the Drupal 6 version. Please tell me if I am wrong.

Muse is currently the only gateway module that uses receive mainly because I have had this rewrite planned and didn't bother adding receive capabilities when the system was going to change anyway.

Anonymous’s picture

Anonymous (not verified) commented

Hmm, yeah the claasic problem of multiple major development tasks running in parallel :) It might be worth the effort if we can port to D6 quickly (like next week), and merge in your refactoring/rewriting. It depends on which part of the code will change most, the core related parts or the internal logic of the module(s), because the latter will make merging much more easy.

My suggestion is to focus on porting to D6 and do all development in that branch (as the D5 version is already functional and released). Concentrating development on D5 will hold back the D6 release for a long time I'm afraid. Why put a new engine in a (running) old car if buying a new car will cost you equally ;)

Just my 2c though...

Will White’s picture

Will White commented
Status: Needs review » Reviewed & tested by the community

Ok I'll commit the most recent Drupal 6 upgrade patch to HEAD and branch for Drupal 6 so we have a development snapshot. Development should then continue on HEAD.

I commited my changes to the DRUPAL-5 branch today so I'll work to make those changes on DRUPAL-6 as well once it's up.

@theonlyharry: Thanks for jump starting this process and your continuing help with the upgrade.

tylor’s picture

tylor commented

@TheOnlyHarry Thanks for your continued work on this port!

I was just thinking that sms_receive needs some more work... to get things rolling though, I should be able to find some time tomorrow to port sms_muse so we can at least test this. Consider sms_muse in my hands.

At some point I think we need to go through and take a close look at the code: we need to document all of the hooks and there should be clear definitions for each.

@diggersf: I saw your comment in the gnokii project that "These two functions are required by sms_receive for some reason. They are not necessary." Obviously this shouldn't happen.

As for sms_og, I originally included it as a sample for how to hook into sms_receive. It should be straightforward to port but we should also be wary of feature creep.

Will White’s picture

Will White commented
StatusFileSize
new sms_4.patch25.45 KB

I've created a new ticket about documentation:
http://drupal.org/node/292392

Ok good calls on all of this. We should just port what we can and then worry about gutting code later! I've just updated the e-mail gateway module and I'm still working on sms_user.

Will White’s picture

Will White commented
Status: Reviewed & tested by the community » Fixed

I just did an initial commit to HEAD so update your WCs. Please create new tickets to report additional problems.

I'll wait a few days for things to settle out before syncing the API changes with the DRUPAL-5 version. I'd say we're on track for a release in 1.5 weeks. After that point the plan is to continue with the roadmap for both versions.

I can't thank everyone enough for helping to patch and test this upgrade so quickly!

tylor’s picture

tylor commented

I just committed support for the Muse gateway as well as some fixes for SMS Receive. (commit #132227)

For those of you who want to test receive, it is simply a callback URL. Try this:

  • enable SMS Framework, SMS Receive, and the Muse gateway
  • set it as the default gateway at admin/smsframework/gateways
  • visit admin/smsframework/receive, choose a content type (eg. 'page') and map the 'from' and 'text' fields
  • check that your permissions will allow anonymous users can create content of the type you selected (eg. 'create page content') and can 'receive sms message'

To 'receive' a message, visit /sms/in?Type=sms&Text=Hello World&From=5555555555 in your browser and it should be created as a new node.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

asak’s picture

asak commented

.... And ? ;)