Closed (won't fix)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
27 Jul 2005 at 19:44 UTC
Updated:
7 Dec 2008 at 19:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ejort commentedIt would be possible to do, I just wrote it for my own sites needs. I also added a few more substitution variables which may be useful for a footer.
I'll try to separate the appropriate changes from my other local features and submit a patch later today.
Cheers,
Eric
Comment #2
ejort commentedOK, as promised, here's my configurable footers patch.
Adds two textareas to the settings page in their own form group, one textarea is for a HTML footer, and the other is for a plain footer.
I've also changed simplenews_replace_vars a little. It now has a few more (undocumented) variables which it will replace (things like %unsubscribe_uri and %archive_uri).
Hope you like it,
Eric
Comment #3
boris mann commentedI'm +1 for this feature...I asked for it combined with another issue.
Comment #4
Tobias Maier commented+1 also from my side...
maybe a special header area is also usefull...
ciao
Comment #5
ejort commentedThanks for your interest. Now that the updated module is out I'm going to port this patch forward to it and make the footer per newsletter. Hopefully I'll be done with that sometime later on this week.
I thought about adding a header option as well... I might do that while I'm working on this, or possibly I could create a template for each newsletter where the body is included via a %body-text variable? How does that sound? Takes care of headers and footers in one text box :-)
Cheers,
Eric
Comment #6
Tobias Maier commentedthis sounds very good for me :D
I thought also about something like a template for the newsletter...
Comment #7
Tobias Maier commentedhow is your patch going on?
ciao tobi
Comment #8
ejort commentedI have this footer feature functioning with the updated module, but it's not yet per newsletter (haven't had time to do that yet). It's still on my todo list though and hopefully I'll get to it within the next week.
Comment #9
bradlis7 commented+1 for this feature. It would be useful to include the logo of your site, like a lot of newsletters do. An example is the redhat magazine, which I think has the same header and footer each time.
I like the %body-text idea. I think the header and footer should only be added to sent out newsletters, not to newsletter node items displayed on the site.
Comment #10
jo1ene commentedThis patch is against the old version pre-January 28, 2006.
+1 for functionality
Comment #11
bradlis7 commentedOnce Mime Mail is used, which is on the simplenews todo list (http://drupal.org/node/40058), this functionality will be available through a theme function (theme_mimemail_message). I was just digging into the code today and found that out, so that will be good. Hopefully, this will be done soon.
Another question though, will everyone want to edit the theme function in order to customize it, or would it be better as a configuration on the site? Most themes on drupal probably aren't going to implement it, for a while at least, so unless you're into php, it's not going to be all that easy.
Comment #12
Anonymous (not verified) commentedWondering what the status is on this--I'm really impressed with this module, and the ability to add a header and footer would be a great addition. I especially like the idea of adding these only to the email version.
Dan
Comment #13
gtcaz commentedIs this related to the message appended to all my newsletters:
"-- Footer will be appended here"
Looks silly and I don't see a way to get rid of it.
Comment #14
gtcaz commentedOops. Sorry about the last post. Didn't realize that was only included in the test message until I sent a trial-run.
Comment #15
rickvug commentedsubscribing
Comment #16
sutharsan commentedWe now have cck and simplenews_templates.
Comment #17
hansrossel commentedYou can translate the unsubscribe footer message with localisation, the string is wrapped in a t function:
"Click here to unsubscribe from this newsletter" and "Unsubscribe from this newsletter: @url"
Comment #18
hansrossel commentedThe footer generated with the Simplenews_templates module does not overrides the unsubscribe footer so is no solution for this problem, see http://drupal.org/node/139305.
I'm using CCK and removed the body field from the simplenews node type, but still have the hard code simplenews "footer will be appended here" footer present. Please explain how CCK would solve this issue.
Comment #19
sutharsan commentedUse theming to override the footer.