Port to Drupal 6.x + Ubercart 2.x

I will do a 6.x release but that will not happen until there is a dev of ubercart and required modules for 6.x. Once those are available and a dev has been released I will try and follow up with a 6.x release of this shortly afterwords. Last I heard there was not a 6.x-dev for ubercart. Is one available now?

I was not aware of that. I will look into it but probably will not make a release until there is an rc or the api has been frozen. Please note that it does say not all of the modules have been ported yet. If i try to make one before then there is a good chance it will change and not work as intended creating lots of additional work for myself.

Thanks bmagistro for your contrubution in drupal. I try the uieforum 5.x-2.3 version, it's very good. I am waiting for 6.x version for my site. Hope it coming soon.

+1

you guys are welcome to try the 5.x-2.2 on 6.x Unless the api's changed for workflow, userpoints, ubercart it should work....if one of you try it and have problems i might be able to get a quick patch together but there is balance bug again

+1 subscribing

+1 subscribing

has anyone tried updating it to 6? I am thinking about giving it a shot and was just wondering.

I guess we were all waiting for bmagistro to do it :-), who is probably waiting for a stable release of D6 Ubercart first.

I believe the workflow-ng module has been replaced in D6 with the rules module. The D6 dev version of the userpoints module seems to have adopted this change, so this may need to be looked at in order to get Ubercat Userpoints working on D6 as well.

I forgot to mention that I 'm more than happy to help out with the testing, if someone ports it over.

Any update on this?

Looking forward to version 6 of this!

I also looking forward to version 6

Ditto for version 6, thank you!

Count my vote! Subscribing!
Thanks!

And me!

+1

+1

+1

+1

+1

+1

Now, all what we need is his home address and a good cellar.
If the d6 version is done, we let him out...

Well... +1 and hoping...

one more....

Here's a patch that updates the Ubercart Userpoints Product 5.x-2.2 module to work with Ubercart 6.x-2.0-beta3.

Caveat:

   * The feature "edit" link doesn't work properly (it creates duplicates when you save).  For now, you can delete the feature and re-add it if you want to change the number of points.
   * This has so far only been tested with "Test Gateway" payments.
   * The other four modules (uc_userpoints_award, uc_userpoints_discount, uc_userpoints_payment, uc_userpoints_seller) are untouched.

Basically, I ran Deadwood on 5.x-2.2, used the Schema module to generate the uc_userpoints_products table for the .install file, and fixed a few minor issues preventing it from working on 6.x.

It's not much, but hopefully it'll help get this moving.

smokris: Were you interested in developing/maintaining a 6.x branch??

bmagistro: i don't really have the time right now to fully develop the 6.x branch, but if you were to give me commit access to the project, i'd be glad to start the 6.x branch and hack on it as i'm able.

Thanks bmagistro and smokris for the module and the update.

Has anyone tried the 6x branch yet? Did you have to make any tweaks to make it work for you?
Connie

+1 subscribing! Thanks for the help so far.

A patch that updates the Ubercart Userpoints Payment 5.x-2.2 module to work with Ubercart 6.x-2.0-beta4.

With this patch I was able to successfully configure some payment settings (admin/store/settings/payment/edit/methods), order a product using userpoints, and delete the same order to get the points refunded. None of the other Ubercart Userpoints modules (_award, _discount, _product, or _seller) were converted or enabled during this testing.

Changes

• Ran the code through Deadwood. Undid a few invalid Deadwood changes.
• Manually added the hook_schema.
• Corrected a hardcoded URL so it uses the l() function.

Notes

• The workflow_ng dependency was removed because workflow_ng has apparently been replaced by the Rules module. If Rules is actually a dependency then the affected code is unknown to me at this point.
• This is my first attempt at a patch, so sorry if I'm goofy things up. Slap me around and point me in the right direction and I'll do better next time.
• I did this quick conversion to help determine if I could get the payments working for a potential client project. If my company lands the project then I'll try to do additional work on Ubercart Userpoints Payments, and possibly (_award, _discount, _product, or _seller).

I find this module is really important - and when i look at the subscriptions, its one of the most wanted atm
in the drupal module community.

Perhaps the ubercart team can add it to ubercart itself?

The idea is to define a "virtual" money/point/credit system which can be inject from outside
(in our case userpoints) to ubercart.

There are so many uses, that i am pretty sure the people asking here for that module come from
pretty different szenarios.

I will open a thread in the ubercart forum, perhaps someone have an idea there.

I opened a forum thread in the ubercart dev board:
http://www.ubercart.org/forum/development/9301/ubercart_usaerpoints

if you have subscribed here, please checkout the ubercart forum thread i posted.

The module there also uses userpoints, and we have now 3 somewhat similiar or
extending modules.

I really would love to see a merged d6 version of all of them.

One of the authors is open for sponsoring, i would give my part if there are others which
would sponsor too.

So, any interest?

I would be happy to chip-in for sponsorship of a D6 version

Being as my current project design is centered around using userpoint as the site currency, I would be willing to help in sponsoring this module.

subscribing and willing to help test

Subscribing - I am hoping to be able to use this on new project.
will help out if possible.

The author of this module pointed out that he is not interested (time, work...) in a D6 version.

You will find here an alternative module:
http://drupal.org/node/379864

The author will create a D6 version if he finds a sponsor...

Are you sure, michtoen?

I know he is busy at the moment with other things, but as of last week he was still commited to putting out a D6 version in the not too distant future (see http://drupal.org/node/389482).

Yes, bmagistro pointed it out explicit in the thread i posted at #34:
'The problem isn't that I do not have an interest in a D6 release of ubercart_userpoints, ...'

I think he also said it somewhat direct here, thats why he is searching for a D6 maintainer in #28.
Well, its all ok - thats how development is and should be handled.

So, don't let wait for him and ask him over and over - we should instead find a different way.
I also have not the time to code it on my own but i will support the development perhaps with a small
donation so other here.

At last there are now 2 projects doing what we all here need.

If anyone is interested I am going to be porting this to drupal 6 this week. I have project that needs the uc_userpoints_award system, so I will finish that up and post what I have done. If anyone is willing to sponsor, I would not see an issue in updating the rest of the module to D6. email is chris@chrismcintoshdesigns.com.

Thanks,
Chris McIntosh

+1 subscribing

+1 subscribing

+1 subscribing

+1

is this still getting ported? I am willing to chipin with as much as I can to a developer who can do it.

Thanks,
Chris

activelyOUT (et al.) --- I'm up for doing it. I'm able to focus on it starting around April 27, and could probably complete it within a week or two.

cmcintosh --- What progress have you made since #43?

and, bmagistro --- I'm willing to take over maintenance of the 6.x version at that point.

That would be great if you would be willing to take on the 6.x branch. I think someone else has finished the couple changes I had left on the 5.x branch but have not had time to review them before posting the fix up here.

I'm very eager to see this ported to D6 soon, since I need a way to issue store credit instead of refunds for cancelled orders. Is there anything I can do (coding, testing, funding, etc) to help make this happen?

Since several people have mentioned funding, I've set up a Chipin for this project.

( My first time using Chipin.. Hopefully this works properly :^] )

Darn, that timeline indicates a completion date after my planned site launch. Is there anything I could contribute on the coding end to help this happen faster?

also rooting for this to get ported to D6 sometime soon. :)

@smokris
Just want to check is the dev started?

Yes, development is underway. We're almost ready with an alpha; I'm going to try to post this in the next couple of days.

subscribe

subscribe!

Dont know if this is too late to do any good. I got the userpoints working as a product feature. There is a bug that for some reason the Type of product feature does not display after you add it to the product, maybe someone can take a look at the code and let me know what im doing wrong, but other than that my alterations of the code get it working.

YOu can assign userpoint values to a product via the product features method, when the order is completed the points are added to correct user.

Thanks and good coding.

http://chrismcintoshdesigns.com
Chris@chrismcintoshdesigns.com

I had to rewrite most of uc_userpoints_product. Smokris was going to upload the tarball I created this week some time (see #56).

In any case, the entire module is ported to drupal 6 pending testing.

has #60 or #59 been officially blessed as the dev version?

I will try either once I know.

Thanks,
C

Please post the latest version. I'm willing to test.

same here

Currently waiting on code review from smokris after I asked about it this afternoon. Should be by this weekend if he isn't busy video editing, qc hacking, working, blogging about NAB, amongst the other things on his plate.

has this been updated? I can't find the release online :(

waiting 4 release 2

Our company has developed a porting of the module to Drupal 6.x which includes the Payment, Products and Discount submodules. Please download it from our website and let us have some feedback. userpoints Module for Ubercart, Drupal 6.x. Following is a list of improvements and acknowledgements.

Major improvements / new features:

• Payment: hides the point price for products that award points
• Points: improved the form for the userpoint feature management
• Generic:
  • fixed some bugs with categorised points
  • PostgreSQL support
  • and ... of course now it works on Drupal 6

What's missing: Awards module and Seller module

Based on original work by bgmagistro - userpoints_ubercart 5.x-2.2
downloaded from http://drupal.org/project/userpoints_ubercart
and various patches taken from http://drupal.org/node/282582:

• submitted by smokris (http://drupal.org/files/issues/uc_userpoints_product-6.x-00.diff)
• submitted by orangecoat-ciallella (http://drupal.org/files/issues/userpoints_ubercart-282582-32.patch)

Thanks mnencia, will test it out soon.

Some notes though, it is better to post it over here so that the code can be tracked, and maybe reduce your bandwidth =)

On the versioning, you should be aware of Userpoint versioning guideline, major version indicate compatibility, which Userpoint only currently at 6.x-1.0. This could avoid confusion to users.

mnencia:

Thank you for taking the time to port this to D6. If you would be willing I would like to let you maintain this release due to my lack of time.

very nice and thanks.
I will test it after the weekend and give some feedback.

+1

thanks @mnencia

maybe you should be assigned this task of porting to D6, as the original task bearer is currently too occupied with school work to be able to complete this.

(I'm awaiting bmagistro's followup on granting me commit access for the project.. I'm planning to roll an official release asap once that's ready.)

@smokris Thanks for the update -- your work is greatly appreciated.

Currently going through mnencia's version and my version that was recently committed to the DRUPAL-6--2 branch. Going to try to get some of those changes in, and then we can get a proper development version.

Current patch for mnencia's version attached, but it still needs to be pruned (patches to the current DRUPAL-6--2 branch). Untested at the moment.

Okay, I have finished going through mnencia's changes and have merged them into a patch for you to commit smokris.

Tested on Postsgres.

Next up, probably need to clean up the comments that still hint at workflow-ng instead of conditional actions in most of the modules. Conditional actions work right now too, just the comments/code needs to be cleaned up. Also, probably want to change the 50% to an actual $ value in the help text for discounts.

Thanks, mradcliffe. I've committed your patch in #76 to the 6.x-2.x branch, and it will be available at http://drupal.org/node/462168 once drupal.org's development snapshot script runs.

Could you please release the 6.x-2.x dev since it's not possible to gain public access to the branch page.

Thanks a lot!

Schneck -

It's now public on http://drupal.org/project/userpoints_ubercart

thanks a lot!

Some code and comment cleanup. I removed the dos line endings in payment.module also.

hey, guys, not sure if you clear this bug, i juz found this during my installations

function uc_userpoints_product_feature_form($node, $feature) {
	$points = 0;

	$nid = arg(1);

	$res = db_query("SELECT * FROM {uc_userpoints_products} ucup, {uc_product_features} ucpf WHERE ucup.pfid = ucpf.pfid AND ucup.nid = %d",$nid);
	while ($pf = db_fetch_object($res)) {
	  $points = $pf->points;
	}

	$form['nid'] = array(
		'#type' => 'value',
		'#value' => $node->nid,
	);

the last line

'#value' => $node->nid,
should be changed to

'#value' => $nid,

Shall we close this thread and file separate issue to the 6.x-2.x-dev since it is already committed?
Putting issue here is hard to track.

For #82
See patch #489624: uc_userpoints_product errors