After fixing http://drupal.org/node/244025 so that the Date Popup would work correctly in multiple value fields that use the new AHAH add more button, the timepicker picked up an odd problem. If you try to click directly into the time field, it would neither work correctly nor even let you enter anything. But if you click first in a date box and then in the time box, it works fine.

I temporarily disabled the javascript in the timepicker until someone can figure this out. I need help from someone who knows javascript. If you want to try it out, uncomment the time form element id so that the javascript will be triggered.

Comments

karens’s picture

karens commented

I've updated to the latest new timepicker code along with the latest new datepicker code. The timepicker is working now, but the behavior is not great. You can tab into the fields and they work fine, but sometimes when you click into them nothing works, but if you click out and then back again they work again.

So this is still buggy and I could use help figuring out how to fix it.

gribnif’s picture

gribnif commented

Some users on a test form I set up recently were confused about how time editing works, period. They didn't expect to have to hit Tab or arrow keys to move between parts of the time. I think this is because of the way the entire text string is presented in a single text field; because of this, they don't think of the hour, minutes, and AM/PM as being separate entities. This was then compounded by the bug described above.

Might it make more sense to split the time field up into two text fields (hour and minute separated by a colon) plus a select for AM/PM? Something like this, only cleaner, is what I had in mind:

<input type=text name=hour size=2>:<input type=text name=minute size=2> <select name=ampm><option>AM</option><option>PM</option></select>

gagarine’s picture

gagarine commented
Status: Active » Closed (duplicate)

EDIT:
Duplicate of http://drupal.org/node/233047

gribnif’s picture

gribnif commented

This thread is a duplicate of itself?

gagarine’s picture

gagarine commented
Status: Closed (duplicate) » Active

oups sorry, it's http://drupal.org/node/233047, I edited my first post.

intent’s picture

intent commented

Agreed. The current time selection process is not intuitive.

Rather than text boxes, I vote for select lists for all three - hour, minute and am/pm. This way, the user can use his/her mouse to select the entire date/time.

arlinsandbulte’s picture

arlinsandbulte commented
Status: Active » Closed (duplicate)

Yep, duplicate of #233047: Switch to using Vega timepicker